Modify

Opened 18 months ago

Closed 14 months ago

Last modified 14 months ago

#20164 closed defect (fixed)

[PATCH] Changset manager: Discussion tab: Problem with scrolling

Reported by: skyper Owned by: team
Priority: normal Milestone: 21.04
Component: Core Version: latest
Keywords: template_report changeset manger discussion scroll Cc:

Description

What steps will reproduce the problem?

  1. Open changeset #85329869 in changeset manager
  2. Open Discussion tab in lower half
  3. Scroll down an watch for rows with large height

What is the expected result?

All context of a row should be visible once when scrolling down

What happens instead?

Only the top part which fits in the window is displayed and the rest is skipped.

Please provide any additional information below. Attach a screenshot if possible.

It only works with the last row. Scrolling at least one complete row does not work here.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-11-26 22:24:27 +0100 (Thu, 26 Nov 2020)
Revision:17364
Build-Date:2020-11-27 02:30:53
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (1)

20164.patch (7.4 KB) - added by Solarspot 14 months ago.
In the attached patch the scrolling logic of this table is borrowed from javax.swing.JTextArea. That makes the scrolling smoother

Download all attachments as: .zip

Change History (5)

comment:1 Changed 14 months ago by Solarspot

Scrolling in a default Swing table aligns window borders with row borders. This is fine if table rows have small and constant height. But if some rows are larger than the others, scrolling becomes confusing. Very large rows are indeed partly skipped.

It would be better if this table is scrolled like a plain text area (e. g. JOSM status report)

Changed 14 months ago by Solarspot

Attachment: 20164.patch added

In the attached patch the scrolling logic of this table is borrowed from javax.swing.JTextArea. That makes the scrolling smoother

comment:2 Changed 14 months ago by Solarspot

Summary: Changset manager: Discussion tab: Problem with scrolling[PATCH] Changset manager: Discussion tab: Problem with scrolling

comment:3 Changed 14 months ago by simon04

Resolution: fixed
Status: newclosed

In 17788/josm:

fix #20164 - Changeset manager: Discussion tab: Problem with scrolling of long comments (patch by Solarspot, modified)

comment:4 Changed 14 months ago by simon04

Milestone: 21.04

I've added the license headers and replaced sun.swing.SwingUtilities2.getFontMetrics with table.getFontMetrics in the test code.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.