Modify

Opened 4 days ago

Closed 3 days ago

Last modified 3 days ago

#19950 closed enhancement (fixed)

Improve Replace Geometry error message

Reported by: nkamapper Owned by: GerdP
Priority: normal Milestone:
Component: Plugin utilsplugin2 Version:
Keywords: replace geometry info box regression Cc:

Description

When two old/existing ways are selected, the Replace Geometry function will display the error message "Both ways are new and have new nodes, cannot decide which one has the correct geometry", which is sometimes confusing.

In this case the error message could be "Please select one way that exists in the database and one new way with correct geometry" or similar.

Attachments (0)

Change History (9)

comment:1 Changed 4 days ago by skyper

Component: CorePlugin utilsplugin2
Keywords: replace geometry info box added

comment:2 Changed 4 days ago by GerdP

Owner: changed from team to GerdP
Status: newassigned

comment:3 Changed 3 days ago by GerdP

Keywords: regression added

Regression from [34844/osm]

comment:4 Changed 3 days ago by GerdP

Resolution: fixed
Status: assignedclosed

In 35597/osm:

fix #19950: Improve Replace Geometry error message

  • Use again "Please select one way that exists in the database and one new way with correct geometry." when both ways are old

comment:5 Changed 3 days ago by GerdP

In 35598/osm:

fix #19950: Improve Replace Geometry error message
dist

comment:6 Changed 3 days ago by GerdP

Seems I totally forgot about this case when I worked on #10225.
@skyper: Reg. a possible dialog: A simpler solution would be to use the order of selection and show a notification that this order was used. Something like Could not decide which way to delete, used the first one in the order of selection

Edit: The big problem with this that the Selection Panel doesn't show the elements in order of selection. It sorts by the displayed data.

Last edited 3 days ago by GerdP (previous) (diff)

comment:7 in reply to:  6 Changed 3 days ago by skyper

Replying to GerdP:

Seems I totally forgot about this case when I worked on #10225.
@skyper: Reg. a possible dialog: A simpler solution would be to use the order of selection and show a notification that this order was used. Something like Could not decide which way to delete, used the first one in the order of selection

Guess, we will not find a more precise message as negative ids are never displayed.

Edit: The big problem with this that the Selection Panel doesn't show the elements in order of selection. It sorts by the displayed data.

Not the first time we find this a bit in-transparent. One solution would be a new sort option in the selection panel: "Sort by selection order".

comment:8 Changed 3 days ago by GerdP

as negative ids are never displayed.

There is an expert option to display them: osm-primitives.showid.new-primitives

comment:9 in reply to:  8 Changed 3 days ago by skyper

Replying to GerdP:

as negative ids are never displayed.

There is an expert option to display them: osm-primitives.showid.new-primitives

Damn, I missed that. The only option not included under "Look and feel" and undocumented: Help/Dialog/SelectionList

Showing the object ids still will only make sense for a few users, who have set this hidden option to true.
Need a different way like highlighting, if we want to give more info.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.