Modify

Opened 6 days ago

Closed 6 days ago

#19949 closed defect (fixed)

[Patch] Don't translate suggested tag values - deprecated sidewalk warning

Reported by: Famlam Owned by: team
Priority: normal Milestone: 20.10
Component: Core validator Version: latest
Keywords: template_report sidewalk translate Cc:

Description (last modified by Famlam)

What steps will reproduce the problem?

  1. Validate a way with sidewalk=yes while using non-English JOSM (in my case Dutch)
  2. Validator warning: sidewalk=yes is niet specifiek. Vervang 'yes' door 'links', 'rechts' of 'beide'.

What is the expected result?

sidewalk=yes is niet specifiek. Vervang 'yes' door 'left', 'right' of 'both'.

What happens instead?

sidewalk=yes is niet specifiek. Vervang 'yes' door 'links', 'rechts' of 'beide'.

Please provide any additional information below. Attach a screenshot if possible.

https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/deprecated.mapcss#L478

Solution 1:

way[sidewalk=yes] {
  throwWarning: tr("{0} is unspecific. Please replace ''{1}'' by ''{2}'', ''{3}'' or ''{4}''.", "{0.tag}", "{0.value}", "left", "right", "both");
}

Solution 2:

way[sidewalk=yes] {
  throwWarning: tr("{0} is unspecific", "{0.tag}");
  suggestAlternative: "sidewalk=left";
  suggestAlternative: "sidewalk=right";
  suggestAlternative: "sidewalk=both";
}

Also a suggestion: also add suggestAlternative: "sidewalk=separate";

(I'm in favor of solution 2)


URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-10-03 13:42:38 +0200 (Sat, 03 Oct 2020)
Build-Date:2020-10-04 01:30:47
Revision:17084
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17084 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 1217 MB / 1820 MB (583 MB allocated, but free)
Java version: 1.8.0_261-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35414)
+ imagery_offset_db (35405)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ reverter (35556)
+ tageditor (35258)
+ turnlanes-tagging (283)
+ undelete (35521)
+ utilsplugin2 (35487)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.mappaint.mapcss

Validator rules:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.validator.mapcss

Last errors/warnings:
- 02510,483 E: Region [WMS_BLOCK_v2] : Failure getting from disk--IOException, key = PDOK Luchtfoto Beeldmateriaal 25cm actueel:https://geodata.nationaalgeoregister.nl/luchtfoto/rgb/wms?REQUEST=GetMap&LAYERS=Actueel_ortho25&STYLES=&FORMAT=image/jpeg&VERSION=1.3.0&CRS=EPSG:3857&WIDTH=512&HEIGHT=512&BBOX=565022.5130840,6814513.9456800,567468.4979892,6816959.9305852EPSG:3857

Attachments (0)

Change History (3)

comment:1 Changed 6 days ago by Famlam

Description: modified (diff)

comment:2 Changed 6 days ago by Klumbumbus

Milestone: 20.10

comment:3 Changed 6 days ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 17216/josm:

  • fix #19949 - Improve warning message for sidewalk=yes (patch by Famlam)
  • Ignore some site tags

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.