Tag2Link : bad link for multi-values

[pyrog]

What steps will reproduce the problem?

1. select ​https://www.openstreetmap.org/node/7871867402
2. right click on wikimedia_commons tag
3. select "Show image on Wikimedia Commons"

What is the expected result?

Open 2 links in the web browser :

• ​https://commons.wikimedia.org/wiki/File:Pyrog_0A6_Maxb--.1_v1.jpg
• ​https://commons.wikimedia.org/wiki/File:Pyrog_0A6_Mawf--.1.jpg

What happens instead?

Wikimedia Commons display the error message "No file by this name exists"

• ​https://commons.wikimedia.org/wiki/File:Pyrog_0A6_Maxb--.1_v1.jpg;File:Pyrog_0A6_Mawf--.1.jpg

Please provide any additional information below. Attach a screenshot if possible.

This a regression (the plugin Tag2Link managed multi-values).

This issue is not specific to Wikimedia Commons images, but all links generated from multi-values (image, mapillary, ref:xx…)

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-07-30 12:44:04 +0200 (Thu, 30 Jul 2020)
Build-Date:2020-07-31 01:30:49
Revision:16812
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16812 fr) Mac OS X 10.14.6
OS Build number: Mac OS X 10.14.6 (18G4032)
Memory Usage: 1002 MB / 1820 MB (445 MB allocated, but free)
Java version: 1.8.0_261-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 69732928 1280x800 (scaling 1.0x1.0)
Maximum Screen Size: 1280x800
Best cursor sizes: 16x16 -> 16x16, 32x32 -> 32x32
VM arguments: [-Djava.library.path=/Applications/JOSM.app/Contents/MacOS, -DLibraryDirectory=${HOME}/Library, -DDocumentsDirectory=${HOME}/Documents, -DApplicationSupportDirectory=${HOME}/Library/Application Support, -DCachesDirectory=${HOME}/Library/Caches, -DApplicationDirectory=${HOME}/Applications, -DAutosavedInformationDirectory=${HOME}/Library/Autosave Information, -DDesktopDirectory=${HOME}/Desktop, -DDownloadsDirectory=${HOME}/Downloads, -DMoviesDirectory=${HOME}/Movies, -DMusicDirectory=${HOME}/Music, -DPicturesDirectory=${HOME}/Pictures, -DSharedPublicDirectory=${HOME}/Public, -DSystemLibraryDirectory=/Library, -DSystemApplicationSupportDirectory=/Library/Application Support, -DSystemCachesDirectory=/Library/Caches, -DSystemApplicationDirectory=/Applications, -DSystemUserDirectory=/Users, -DUserHome=${HOME}, -DSandboxEnabled=true, -DLaunchModifierFlags=0, -DLaunchModifierFlagCapsLock=false, -DLaunchModifierFlagShift=false, -DLaunchModifierFlagControl=false, -DLaunchModifierFlagOption=false, -DLaunchModifierFlagCommand=false, -DLaunchModifierFlagNumericPad=false, -DLaunchModifierFlagHelp=false, -DLaunchModifierFlagFunction=false, -Dapple.laf.useScreenMenuBar=true, -Dcom.apple.macos.use-file-dialog-packages=true, -Dcom.apple.macos.useScreenMenuBar=true, -Dcom.apple.mrj.application.apple.menu.about.name=JOSM, -Dcom.apple.smallTabs=true]
Dataset consistency test: No problems found

Plugins:
+ PicLayer (35405)
+ apache-commons (35524)
+ apache-http (35092)
+ areaselector (368)
+ austriaaddresshelper (1597341117)
+ buildings_tools (35500)
+ cadastre-fr (35405)
+ conflation (0.6.6)
+ ejml (35313)
+ geotools (35169)
+ jaxb (35092)
+ jna (35092)
+ jts (35122)
+ log4j (35092)
+ measurement (35405)
+ opendata (35513)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ reverter (35499)
+ utilsplugin2 (35487)
+ wikipedia (1.1.4)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Towers&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Telecom&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Healthcare&zip=1
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/master/dist/name-suggestions.presets.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/NumberedWalkingNodeNetworks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1

Validator rules:
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip
+ ${HOME}/Downloads/Rules_Pictures.validator.mapcss

Last errors/warnings:
- W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out

[simon04]

In 17006/josm:

fix #19754 - Tag2Link: support multi-values for wikimedia_commons

[skyper]

Sometimes, I have multiple urls as values for source=*. Is it possible to support multi-values in all supported tags, please? - Thanks

[pyrog]

Thanks guys :)

[pyrog]

Fixed for wikimedia_commons, thanks again :)
…but not fixed for other tags ;)

Example with image tag

What steps will reproduce the problem?

1. select ​https://www.openstreetmap.org/node/5699800071
2. right click on image tag
3. select "Show image"

What happens instead?

Not Found. The requested URL was not found on this server.
-​https://carto.atlasante.fr/IHM/cartes/ressources/dae/5e4510aa0063f.jpeg;https://carto.atlasante.fr/IHM/cartes/ressources/dae/5e4510aa03861.jpeg

Example with mapillary

What steps will reproduce the problem?

1. ​https://www.openstreetmap.org/node/4308079617

…

What happens instead?

Sorry, we can't find the image you're looking for. Most likely, the image is still under processing and will be visible soon. Please check back later. If you need more help, contact us.

• ​https://www.mapillary.com/app?focus=photo&pKey=2TUZxmxZqROjxYKT9t0siQ;yyej5QKcpMrVtKJ-IHpciA

Example wit ref:bag tag

What steps will reproduce the problem?

1. ​https://www.openstreetmap.org/way/284061908

…

What happens instead?

No error message but don't zoom to building ​0439100000009661 and building ​0439100000008474

Link generated :

• ​https://bagviewer.kadaster.nl/lvbag/bag-viewer/index.html#?searchQuery=439100000009661;439100000008474&geometry.x=160000&geometry.y=455000&zoomlevel=0

[skyper]

Ticket #20350 has been marked as a duplicate of this ticket.

[skyper]

Replying to skyper:

Sometimes, I have multiple urls as values for source=*. Is it possible to support multi-values in all supported tags, please? - Thanks

Example of #20350:

source=https://ptna.openstreetmap.de/gtfs/DE/trips.php?feed=DE-BW-VAG&release_date=2020-12-16&route_id=10-33-I-j21-1; https://ptna.openstreetmap.de/gtfs/DE/trips.php?feed=DE-BW-VAG&release_date=2020-12-16&route_id=13-33-I-j21-1

[simon04]

In 17735/josm:

fix #19754 - Tag2Link: support multi-values for URLs in website/source/url/image

[skyper]

Thanks a lot.

[anonymous]

thank you 😀