Reconsider/unify icons for osm object types

[Klumbumbus]

We have different sets of icons for the osm object types. This can be confusing especially for new JOSM users. I think about cleaning this up a bit.

Starting point:

	node	way	closedway	mp/area	relation	object	changeset	join areas
Lots of places in the gui
Preset window
Preset and preset group
Others
OSM wiki

Result:

	node	way	closedway	mp/area	relation	object	changeset	join areas
Lots of places in the gui
Preset window
Preset and preset group
Others
OSM wiki

(​osmwiki:Template:Icon)

[stoecker]

Preset window and OSM wiki should be identical. Probably wiki changed and we didn't update.

I'd keep the first and second (after fixing it to current wiki style) and try to get rid of the others.

[stoecker]

Multipolygon/area as one

[stoecker]

Maybe the wheel for relation in first should be replaced by the rings of presets group?

[Klumbumbus]

Replying to stoecker:

Multipolygon/area as one

It's not exactly the same. In JOSM multipolygon means multipolygon only. In OSM wiki area means multipolygon and closedway.

[Klumbumbus]

Replying to stoecker:

Preset window and OSM wiki should be identical.

My first thought was to completely replace the preset icon set in JOSM with the gui icon set.

[Klumbumbus]

Replying to stoecker:

Maybe the wheel for relation in first should be replaced by the rings of presets group?

Yes, I think we should get rid of the gearwheel for relations, because It doesn't represent relations well, and in most applications the gearwheel mens "settings".

[stoecker]

It's not exactly the same. In JOSM multipolygon means multipolygon only. In OSM wiki area means multipolygon and closedway.

I know. But I think it's close enough. ;-)

My first thought was to completely replace the preset icon set in JOSM with the gui icon set.

Well. I think the GUI icons of line 1 much better fit the need of JOSM. The display of the preset style icons is meant as reference to OSM wiki. Using the GUI icons there is probably not an improvement.

Two sets of very similar icons sets probably are ok.

Yes, I think we should get rid of the gearwheel for relations, because It doesn't represent relations well, and in most applications the gearwheel mens "settings".

On a second though, maybe an OSM wiki relation variant in the GUI style of line 1 would be a better solution? I.e. a larger dot with lines to 4 smaller dots.

[Klumbumbus]

Replying to stoecker:

Well. I think the GUI icons of line 1 much better fit the need of JOSM. The display of the preset style icons is meant as reference to OSM wiki. Using the GUI icons there is probably not an improvement.

OK, lets go this way.

On a second though, maybe an OSM wiki relation variant in the GUI style of line 1 would be a better solution? I.e. a larger dot with lines to 4 smaller dots.

Yes, I think something like that makes most sense.

[Klumbumbus]

In 16976/josm:

see #19726 - Update OSM wiki object type icons (taken from e.g. ​https://wiki.openstreetmap.org/wiki/File:Osm_element_closedway.svg), resized, adapt our multipolygon variant, all PD and CC0 licensed

[Klumbumbus]

In 35539/osm:

see #19726 - Update plugin to JOSM version 16976

[Klumbumbus]

In 17029/josm:

• see #19726 - Unify changeset icon, use globe icon in history window version table popup menu, as it opens in the browser
• see #19714 - Typo in comment

[Klumbumbus]

New multipolygon and relation icon with their friends:

[stoecker]

Looks good to me.

[Klumbumbus]

In 17031/josm:

see #19726 - Unify multipolygon and relation icons, all self created, partly derived from existing icons, all PD and CC0 licensed, dialogs/addrelation replaced by normal add and normal relation icon

[Klumbumbus]

Dirk, could you please assign the new icon multipoly_update.svg to the update variant of the action in CreateMultipolygonAction.java? TY

[stoecker]

In 17033/josm:

see #19726, separate icons for update and create multipolygon

[Klumbumbus]

Thx.