Modify ↓

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19725 closed enhancement (fixed)

ImageProvider/ImageResource: extract size computation code

Reported by: simon04 Owned by: simon04
Priority: normal Milestone: 20.08
Component: Core Version:
Keywords: refactoring imagesize padded bounded Cc:

Description


Attachments (0)

Change History (11)

comment:1 Changed 2 years ago by simon04

Resolution: → fixed
Status: assigned → closed

In 16946/josm:

fix #19706, fix #19725 - ImageProvider/ImageResource: extract ImageResizeMode, add HiDPI support to bounded/padded icons

comment:2 Changed 2 years ago by simon04

In 16978/josm:

fix #19706, fix #19725 - Do not upscale images when using ImageResizeMode.BOUNDED

comment:3 Changed 2 years ago by simon04

In 16980/josm:

see #19706, see #19725 - Fix HiDPI with ImageResizeMode.BOUNDED

Regression of r16978

comment:4 Changed 2 years ago by simon04

In 16982/josm:

see #19706, see #19725 - ImageProviderTest: add tests comparing the result with reference images

comment:5 Changed 2 years ago by simon04

In 16989/josm:

see #19706, see #19725 - ImageProviderTest: add tests comparing the result with reference images (separate images for Java 8)

comment:6 Changed 2 years ago by simon04

In 16997/josm:

see #19706, see #19725 - ImageProvider: re-activate upscaling of SVG images

comment:7 Changed 2 years ago by simon04

In 16998/josm:

see #19706, see #19725 - ImageProvider: improve resize quality for raster images

comment:8 Changed 2 years ago by simon04

In 17005/josm:

see #19706, see #19725 - Fix ImageResizeModeTest.testCacheKey

comment:9 in reply to:  7 Changed 2 years ago by skyper

Replying to simon04:

In 16998/josm:

see #19706, see #19725 - ImageProvider: improve resize quality for raster images

This change triggered a PMD Warning: https://josm.openstreetmap.de/jenkins/job/JOSM/6756/

comment:10 Changed 2 years ago by stoecker

And the tests fail.

comment:11 Changed 2 years ago by Don-vip

In 17074/josm:

see #19706, see #19725 - PMD - avoid throwing NPE

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.