Modify

Opened 3 weeks ago

Closed 4 days ago

#19726 closed enhancement (fixed)

Reconsider/unify icons for osm object types

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 20.09
Component: Core Version:
Keywords: icon Cc:

Description (last modified by Klumbumbus)

We have different sets of icons for the osm object types. This can be confusing especially for new JOSM users. I think about cleaning this up a bit.

Starting point:

node way closedway mp/area relation object changeset join areas
Lots of places in the gui source:josm/trunk/resources/images/data/node.svg@16975 source:josm/trunk/resources/images/data/way.svg@16975 source:josm/trunk/resources/images/data/closedway.svg@16975 source:josm/trunk/resources/images/data/multipolygon.svg@16975 source:josm/trunk/resources/images/data/relation.svg@16975 source:josm/trunk/resources/images/data/object.svg@16975 source:josm/trunk/resources/images/dialogs/changesetdialog.svg@16975
Preset window source:josm/trunk/resources/images/Mf_node.svg@16975 source:josm/trunk/resources/images/Mf_way.svg@16975 source:josm/trunk/resources/images/Mf_closedway.svg@16975 source:josm/trunk/resources/images/Mf_multipolygon.svg@16975 source:josm/trunk/resources/images/Mf_relation.svg@16975
Preset and preset group source:josm/trunk/resources/images/presets/misc/multipolygon.svg@16975 source:josm/trunk/resources/images/presets/misc/relations.svg@16975
Others source:josm/trunk/resources/images/multipoly_create.svg@16975 source:josm/trunk/resources/images/dialogs/addrelation.svg@16975 source:josm/trunk/resources/images/data/changeset.svg@16975 source:josm/trunk/resources/images/joinareas.svg@16975
OSM wiki

Result:

node way closedway mp/area relation object changeset join areas
Lots of places in the gui source:trunk/resources/images/data/node.svg source:trunk/resources/images/data/way.svg source:trunk/resources/images/data/closedway.svg source:trunk/resources/images/data/multipolygon.svg source:trunk/resources/images/data/relation.svg source:trunk/resources/images/data/object.svg source:trunk/resources/images/dialogs/changesetdialog.svg
Preset window source:trunk/resources/images/Osm_element_node.svg source:trunk/resources/images/Osm_element_way.svg source:trunk/resources/images/Osm_element_closedway.svg source:trunk/resources/images/Osm_element_multipolygon.svg source:trunk/resources/images/Osm_element_relation.svg
Preset and preset group source:trunk/resources/images/presets/misc/multipolygon.svg source:trunk/resources/images/presets/misc/relations.svg
Others source:trunk/resources/images/multipoly_create.svg source:trunk/resources/images/joinareas.svg
OSM wiki

(osmwiki:Template:Icon)

Attachments (7)

Osm_element_node.svg (1.5 KB) - added by Klumbumbus 3 weeks ago.
Osm_element_way.svg (1.6 KB) - added by Klumbumbus 3 weeks ago.
Osm_element_closedway.svg (1.6 KB) - added by Klumbumbus 3 weeks ago.
Osm_element_area.svg (1.6 KB) - added by Klumbumbus 3 weeks ago.
Osm_element_relation.svg (1.9 KB) - added by Klumbumbus 3 weeks ago.
19726_starting_point.png (14.1 KB) - added by Klumbumbus 3 weeks ago.
19726a.PNG (3.3 KB) - added by Klumbumbus 5 days ago.

Download all attachments as: .zip

Change History (40)

comment:1 Changed 3 weeks ago by Klumbumbus

Description: modified (diff)

comment:2 Changed 3 weeks ago by Klumbumbus

Description: modified (diff)

comment:3 Changed 3 weeks ago by Klumbumbus

Description: modified (diff)

comment:4 Changed 3 weeks ago by Klumbumbus

Description: modified (diff)

comment:5 Changed 3 weeks ago by Klumbumbus

Description: modified (diff)

Changed 3 weeks ago by Klumbumbus

Attachment: Osm_element_node.svg added

Changed 3 weeks ago by Klumbumbus

Attachment: Osm_element_way.svg added

Changed 3 weeks ago by Klumbumbus

Attachment: Osm_element_closedway.svg added

Changed 3 weeks ago by Klumbumbus

Attachment: Osm_element_area.svg added

Changed 3 weeks ago by Klumbumbus

Attachment: Osm_element_relation.svg added

comment:6 Changed 3 weeks ago by Klumbumbus

Description: modified (diff)

comment:7 Changed 3 weeks ago by Klumbumbus

Description: modified (diff)

comment:8 Changed 3 weeks ago by stoecker

Preset window and OSM wiki should be identical. Probably wiki changed and we didn't update.

I'd keep the first and second (after fixing it to current wiki style) and try to get rid of the others.

comment:9 Changed 3 weeks ago by Klumbumbus

Milestone: 20.09

comment:10 Changed 3 weeks ago by stoecker

Description: modified (diff)

Multipolygon/area as one

comment:11 Changed 3 weeks ago by stoecker

Maybe the wheel for relation in first should be replaced by the rings of presets group?

comment:12 in reply to:  10 Changed 3 weeks ago by Klumbumbus

Replying to stoecker:

Multipolygon/area as one

It's not exactly the same. In JOSM multipolygon means multipolygon only. In OSM wiki area means multipolygon and closedway.

comment:13 in reply to:  8 Changed 3 weeks ago by Klumbumbus

Replying to stoecker:

Preset window and OSM wiki should be identical.

My first thought was to completely replace the preset icon set in JOSM with the gui icon set.

comment:14 in reply to:  11 Changed 3 weeks ago by Klumbumbus

Replying to stoecker:

Maybe the wheel for relation in first should be replaced by the rings of presets group?

Yes, I think we should get rid of the gearwheel for relations, because It doesn't represent relations well, and in most applications the gearwheel mens "settings".

comment:15 Changed 3 weeks ago by stoecker

It's not exactly the same. In JOSM multipolygon means multipolygon only. In OSM wiki area means multipolygon and closedway.

I know. But I think it's close enough. ;-)

My first thought was to completely replace the preset icon set in JOSM with the gui icon set.

Well. I think the GUI icons of line 1 much better fit the need of JOSM. The display of the preset style icons is meant as reference to OSM wiki. Using the GUI icons there is probably not an improvement.

Two sets of very similar icons sets probably are ok.

Yes, I think we should get rid of the gearwheel for relations, because It doesn't represent relations well, and in most applications the gearwheel mens "settings".

On a second though, maybe an OSM wiki relation variant in the GUI style of line 1 would be a better solution? I.e. a larger dot with lines to 4 smaller dots.

comment:16 in reply to:  15 Changed 3 weeks ago by Klumbumbus

Replying to stoecker:

Well. I think the GUI icons of line 1 much better fit the need of JOSM. The display of the preset style icons is meant as reference to OSM wiki. Using the GUI icons there is probably not an improvement.

OK, lets go this way.

On a second though, maybe an OSM wiki relation variant in the GUI style of line 1 would be a better solution? I.e. a larger dot with lines to 4 smaller dots.

Yes, I think something like that makes most sense.

Changed 3 weeks ago by Klumbumbus

Attachment: 19726_starting_point.png added

comment:17 Changed 3 weeks ago by Klumbumbus

Description: modified (diff)

comment:18 Changed 3 weeks ago by Klumbumbus

In 16976/josm:

see #19726 - Update OSM wiki object type icons (taken from e.g. https://wiki.openstreetmap.org/wiki/File:Osm_element_closedway.svg), resized, adapt our multipolygon variant, all PD and CC0 licensed

comment:19 Changed 3 weeks ago by Klumbumbus

Description: modified (diff)

comment:20 Changed 3 weeks ago by Klumbumbus

Description: modified (diff)

comment:21 Changed 3 weeks ago by Klumbumbus

In 35539/osm:

see #19726 - Update plugin to JOSM version 16976

comment:22 Changed 6 days ago by Klumbumbus

In 17029/josm:

  • see #19726 - Unify changeset icon, use globe icon in history window version table popup menu, as it opens in the browser
  • see #19714 - Typo in comment

comment:23 Changed 6 days ago by Klumbumbus

Description: modified (diff)

comment:24 Changed 5 days ago by Klumbumbus

Description: modified (diff)

comment:25 Changed 5 days ago by Klumbumbus

Description: modified (diff)

Changed 5 days ago by Klumbumbus

Attachment: 19726a.PNG added

comment:26 Changed 5 days ago by Klumbumbus

New multipolygon and relation icon with their friends:

(mp icon slightly changed afterwards)

Last edited 5 days ago by Klumbumbus (previous) (diff)

comment:27 Changed 5 days ago by stoecker

Looks good to me.

comment:28 Changed 5 days ago by Klumbumbus

Description: modified (diff)

comment:29 Changed 5 days ago by Klumbumbus

In 17031/josm:

see #19726 - Unify multipolygon and relation icons, all self created, partly derived from existing icons, all PD and CC0 licensed, dialogs/addrelation replaced by normal add and normal relation icon

comment:30 Changed 5 days ago by Klumbumbus

Dirk, could you please assign the new icon multipoly_update.svg to the update variant of the action in CreateMultipolygonAction.java? TY

comment:31 Changed 5 days ago by Klumbumbus

Description: modified (diff)

comment:32 Changed 4 days ago by stoecker

In 17033/josm:

see #19726, separate icons for update and create multipolygon

comment:33 Changed 4 days ago by Klumbumbus

Resolution: fixed
Status: newclosed

Thx.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.