Modify

Opened 4 weeks ago

Closed 8 days ago

Last modified 6 days ago

#19714 closed enhancement (fixed)

[PATCH] Visually differentiate barrier=city_wall left and right sides

Reported by: gaben Owned by: team
Priority: minor Milestone: 20.09
Component: Internal mappaint style Version: latest
Keywords: Cc:

Description

According to the wiki:
"Behaves same as natural=cliff, that is no crossing as left-right are different height. Lower side on right side of way direction.."

Currently, in JOSM, the left and right sides are not differentiated visually.

Attachments (1)

19714v1_(WIP).patch (3.1 KB) - added by gaben 2 weeks ago.
Ignore directional ways which have two_sided=yes tag

Download all attachments as: .zip

Change History (19)

comment:1 Changed 4 weeks ago by skyper

Needs to be added for special handling to the revert way action, too.

comment:2 Changed 4 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 16938/josm:

  • fix #19714 - Add rendering of right side of barrier=city_wall
  • Add two_sided=yes checkbox to barrier=city_wall preset
  • Fix unpredictable rendering of patterns

comment:3 in reply to:  1 Changed 4 weeks ago by Klumbumbus

Replying to skyper:

Needs to be added for special handling to the revert way action, too.

Oh, I didn't see your comment.

comment:4 Changed 4 weeks ago by Klumbumbus

In 16939/josm:

  • see #19714 - Warn if barrier=city_wall way is reversed

comment:5 Changed 4 weeks ago by Klumbumbus

Resolution: fixed
Status: closedreopened

I don't know how to exclude the special case when two_sided=yes is tagged (regarding the way reverse warning).

Last edited 3 weeks ago by Klumbumbus (previous) (diff)

comment:6 Changed 4 weeks ago by Klumbumbus

Milestone: 20.08

comment:7 in reply to:  5 Changed 3 weeks ago by gaben

Replying to Klumbumbus:

I don't know how to exclude the special case when two_sided=yes is tagged (regarding the way reverse warning).

Probably an extra check around here: https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/actions/corrector/ReverseWayNoTagCorrector.java?rev=16939#L58
It would be ugly but could work.

comment:8 Changed 3 weeks ago by Klumbumbus

I tried that already but failed with my "copy paste java knowledge" :D

comment:9 Changed 2 weeks ago by stoecker

Please explain what needs to be done (also related to the other tags of the tag corrector).

comment:10 Changed 2 weeks ago by skyper

So far the code only checks for single tags, only, but in cases of barrier=city_wall together with two_sided=yes there should be no warning. So we need the possibility to exclude this combination.

comment:11 Changed 2 weeks ago by stoecker

Milestone: 20.0820.09

comment:12 Changed 2 weeks ago by gaben

I did a bit of research. Although the two_sided=yes attribute used mostly only on city_walls but also on guard_rails, walls, kerbs and a few more. City_wall has over 4k, others <100 occurrences. I have a patch for city_wall only. Is it enough?

comment:13 in reply to:  12 ; Changed 2 weeks ago by skyper

Replying to gaben:

I did a bit of research. Although the two_sided=yes attribute used mostly only on city_walls but also on guard_rails, walls, kerbs and a few more. City_wall has over 4k, others <100 occurrences. I have a patch for city_wall only. Is it enough?

Think patches are always welcome. Is it possible, to exclude two_sided=yes, in general, no matter what the additional tags are? Are there any use cases where reverting the way directions is a problem?

Last edited 2 weeks ago by skyper (previous) (diff)

Changed 2 weeks ago by gaben

Attachment: 19714v1_(WIP).patch added

Ignore directional ways which have two_sided=yes tag

comment:14 in reply to:  13 Changed 2 weeks ago by gaben

Summary: Visually differentiate barrier=city_wall left and right sides[PATCH] Visually differentiate barrier=city_wall left and right sides

Replying to skyper:

Is it possible, to exclude two_sided=yes, in general, no matter what the additional tags are?

Absolutely. It's the easiest solution :)

Are there any use cases where reverting the way directions is a problem?

The patch only affects ways, which are directional + have two_sided=yes tag. So probably not a problem.

comment:15 Changed 8 days ago by stoecker

Resolution: fixed
Status: reopenedclosed

In 17023/josm:

fix #19714, patch by gaben, don't complain about direction reversal in case of two_sided=yes

comment:16 Changed 6 days ago by gaben

Ah sorry, the ticket reference in the comment got an extra 0 at the end :(

-// two_sided=yes is a special (documented) barrier=city_wall attribute, see #197140
+// two_sided=yes is a special (documented) barrier=city_wall attribute, see #19714

source:trunk/src/org/openstreetmap/josm/actions/corrector/ReverseWayNoTagCorrector.java?rev=17023#L62

Last edited 6 days ago by stoecker (previous) (diff)

comment:17 Changed 6 days ago by Klumbumbus

In 17029/josm:

  • see #19726 - Unify changeset icon, use globe icon in history window version table popup menu, as it opens in the browser
  • see #19714 - Typo in comment

comment:18 Changed 6 days ago by gaben

Thanks! :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.