Modify

Opened 14 months ago

Last modified 4 weeks ago

#19722 new defect

Turn restriction validator warning inconsistency

Reported by: Famlam Owned by: team
Priority: normal Milestone:
Component: Core validator Version: tested
Keywords: template_report turn restriction Cc:

Description (last modified by Famlam)

Both TurnrestrictionTest.java and relation.mapcss throw a validation warning in the case of a turn restriction (relation with type=restriction) without a restriction=... key.
The mapcss one explicitly does not warn in case of restriction:mode=value (i.e. restriction:hgv=no_left_turn) instead of restriction=value. The java test however still gives an error in this case.

Basically there are two errors here:

  1. A double warning is shown if no restriction key is present (the mapcss test seems superfluous)
  2. The java test doesn't take into account transportation-mode-limited restrictions. According to the wiki, restriction:mode=* is also valid.

Expected: no warning if

  • restriction + type=restriction + restriction=no_left_turn
  • restriction + type=restriction + restriction:foot=no_left_turn

Expected: only 1 warning if

  • restriction + type=restriction
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-07-30 12:44:04 +0200 (Thu, 30 Jul 2020)
Build-Date:2020-07-31 01:30:49
Revision:16812
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16812 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 817 MB / 1820 MB (142 MB allocated, but free)
Java version: 1.8.0_261-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35414)
+ imagery_offset_db (35405)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ tageditor (35258)
+ turnlanes-tagging (283)
+ undelete (35499)
+ utilsplugin2 (35487)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Validator rules:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.validator.mapcss

Attachments (0)

Change History (3)

comment:1 Changed 14 months ago by Famlam

Description: modified (diff)

comment:2 Changed 6 months ago by skyper

Most of the java tests could be rewritten in mapcss, only the connection tests might be a quest in mapcss but counting member roles is easy.

With #20833 the java tests need to be adjusted anyway and #20832 is another ticket asking for changes.

comment:3 Changed 4 weeks ago by skyper

How about dropping the java test and raising the mapccs warning to error level?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to Famlam
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.