Tagging presets: Icons for all preset input boxes

[skyper]

I want to add a icon to <text /> and a general icon for <combo /> and multiselect. Currently only <check /> supports this.

What steps will reproduce the problem?

1. Have <combo /> in preset.
2. Try to add a general icon to the preset line behind the text

What is the expected result?

An option similar to <check /> to add a general icon

What happens instead?

No option, no icon

Please provide any additional information below. Attach a screenshot if possible.

In the example below I'd like to have an icon for bicyle and wheelchair.

I could use this in #17750 and the "Access Restrictions" preset would profit a lot from this as I was already thinking about this request for #18698.

Thanks a lot.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-07-18 00:43:51 +0200 (Sat, 18 Jul 2020)
Revision:16792
Build-Date:2020-07-18 01:30:56
URL:https://josm.openstreetmap.de/svn/trunk

[simon04]

In 17605/josm:

fix #19554 - Tagging presets: Icons for all preset input boxes

[simon04]

@skyper, would you please update TaggingPresets? Thanks!

[skyper]

Replying to simon04:

@skyper, would you please update TaggingPresets? Thanks!

Thanks for the enhancement. Hope to have time to test and document it next week. Please, remind me in a few weeks.

[Don-vip]

Some compiler warnings:

    [javac] C:\SVN\josm\core\src\org\openstreetmap\josm\gui\preferences\server\OAuthAuthenticationPreferencesPanel.java:175: warning: [UnusedVariable] The local variable 'gc' is never read.
    [javac]             GridBagConstraints gc = new GridBagConstraints();
    [javac]                                ^
    [javac]     (see https://errorprone.info/bugpattern/UnusedVariable)
    [javac]   Did you mean to remove this line or 'new GridBagConstraints();'?
    [javac] C:\SVN\josm\core\src\org\openstreetmap\josm\gui\tagging\presets\items\Check.java:35: warning: [HidingField] Hiding fields of superclasses may cause confusion and errors. This field is hiding a field of the same name in superclass: TextItem
    [javac]     public String icon; // NOSONAR
    [javac]                   ^
    [javac]     (see https://errorprone.info/bugpattern/HidingField)
    [javac] C:\SVN\josm\core\src\org\openstreetmap\josm\gui\tagging\presets\items\Check.java:37: warning: [HidingField] Hiding fields of superclasses may cause confusion and errors. This field is hiding a field of the same name in superclass: TextItem
    [javac]     public short icon_size = 16; // NOSONAR
    [javac]                  ^
    [javac]     (see https://errorprone.info/bugpattern/HidingField)

[simon04]

In 17607/josm:

see #19554 - Java Warnings

[simon04]

In 17608/josm:

see #19554 - Checkstyle

[skyper]

Replying to skyper:

Replying to simon04:

@skyper, would you please update TaggingPresets? Thanks!

Thanks for the enhancement. Hope to have time to test and document it next week. Please, remind me in a few weeks.

Hope I got all changes in the correct place: wiki:TaggingPresets?action=diff&version=177&old_version=176

[skyper]

I played around a bit with this new option, nice. Too bad, that some of our icons are not of best quality, especially, regarding different background colors and dark mode. It seems that some work on icons is needed first until this improvement will enter defaultpresets.