Modify

Opened 8 months ago

Last modified 9 days ago

#19464 new enhancement

Consider reducing priority of credit card validator warning (payment tags) [PATCH]

Reported by: mkoniecz Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report Cc:

Description (last modified by mkoniecz)

What steps will reproduce the problem?

  1. Create node
  2. Add payment:credit_cards=yes
  3. Run validator

What is the expected result?

No complaints or complaints at info level

What happens instead?

payment:credit_cards=yes is inaccurate. Use separate tags for each specific type, e.g. payment:mastercard=yes or payment:visa=yes. (1)

Please provide any additional information below. Attach a screenshot if possible.

At least in Poland spending time on providing more specific info would be complete waste of time. Anything supporting credit cards will support mastercard and visa duopoly, there is basically no use of other credit cards.

This warning really should be at info level.

For additional context: I considered implementing StreetComplete quest collecting this info (like I did for some other missing values, AFAIK some inspired by JOSM validator warnings). But I decided that it would be waste of time - both for developing and both for collecting data. At least in areas known to me.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-06-13 13:23:27 +0200 (Sat, 13 Jun 2020)
Revision:16613
Build-Date:2020-06-14 01:30:46
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (16613 en_GB) Linux Ubuntu 20.04 LTS
Memory Usage: 274 MB / 976 MB (48 MB allocated, but free)
Java version: 11.0.7+10-post-Ubuntu-3ubuntu1, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 16x16, 32x32 -> 32x32
Java package: openjdk-11-jre:amd64-11.0.7+10-3ubuntu1
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (35474)
+ measurement (35405)
+ reverter (35487)
+ todo (30306)

Attachments (0)

Change History (6)

comment:1 Changed 8 months ago by mkoniecz

Description: modified (diff)

comment:2 Changed 9 days ago by mkoniecz

Summary: Consider reducing priority of credit card validator warningConsider reducing priority of credit card validator warning (payment tags)

comment:3 Changed 9 days ago by mkoniecz

After looking at this again (triggered by other user complaining about this) - this warning makes no sense at all in Poland. Does it make sense anywhere at all?

And at least in my opinion tagging this is basically pointless - if I would think otherwise I would implement a StreetComplete quest asking about this.

Last edited 9 days ago by mkoniecz (previous) (diff)

comment:4 Changed 9 days ago by mkoniecz

Trivial patch made with git format-patch, let me know if a different format is preffered

From 8b5ab733eab58767372c882082afc9ccbf1d1700 Mon Sep 17 00:00:00 2001
From: Mateusz Konieczny <matkoniecz@gmail.com>
Date: Wed, 17 Feb 2021 08:47:31 +0100
Subject: [PATCH] stop complaining about not listing specific credit card
 brands

at least in areas familiar to me, this warning is a pointless noise that is not worth handling
---
 resources/data/validator/deprecated.mapcss | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/resources/data/validator/deprecated.mapcss b/resources/data/validator/deprecated.mapcss
index e5420bad8..bb875f5ad 100644
--- a/resources/data/validator/deprecated.mapcss
+++ b/resources/data/validator/deprecated.mapcss
@@ -702,9 +702,9 @@ relation[/^..$/][!to] {
   fixAdd: "sport=billiards";
 }
 
-/* #11499, #16928 */
+/* #11499, #16928, #19464 */
 *[payment:credit_cards=yes] {
-  throwWarning: tr("{0} is inaccurate. Use separate tags for each specific type, e.g. {1} or {2}.", "{0.tag}", "payment:mastercard=yes", "payment:visa=yes");
+  throwOther: tr("{0} is inaccurate. Use separate tags for each specific type, e.g. {1} or {2}.", "{0.tag}", "payment:mastercard=yes", "payment:visa=yes");
 }
 *[payment:debit_cards=yes] {
   throwWarning: tr("{0} is inaccurate. Use separate tags for each specific type, e.g. {1} or {2}.", "{0.tag}", "payment:maestro=yes", "payment:girocard=yes");
-- 
2.30.0
Last edited 9 days ago by mkoniecz (previous) (diff)

comment:5 Changed 9 days ago by mkoniecz

Summary: Consider reducing priority of credit card validator warning (payment tags)Consider reducing priority of credit card validator warning (payment tags) [PATCH]

comment:6 Changed 9 days ago by Mxdanger

I agree with this change about decreasing the significance of payment:credit_cards=yes. I have this same problem in my area and getting warnings when I'm using the more appropriate payment:credit_cards=yes instead of adding dozens of payment methods that end up being less useful or practical when all the end user wants to know is if the point of interest supports credit cards or not. Which exact credit card brands are supported is already implied based on the user's location and the only time I need to be specific about what payment methods are listed is when to explicitly mark them as no.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to mkoniecz
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.