Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11499 closed defect (fixed)

Wrong validator result: Value 'yes' for key 'payment:credit_cards' not in preset.

Reported by: mdk Owned by: team
Priority: normal Milestone: 15.08
Component: Core validator Version: latest
Keywords: Cc:

Description

The node 1589860488 contains three payment types:

payment:cash=yes
payment:credit_cards=yes
payment:telephone_cards=yes

But only for payment:credit_cards the value 'yes' is unknown (the key itself is known)!

Attachments (0)

Change History (9)

comment:1 Changed 4 years ago by Klumbumbus

This is because payment:credit_cards=yes is not helpful information. You should use payment:mastercard=yes or payment:visa=yes, or ...

You can use payment:credit_cards=no to indicate that there are no credit cards accepted at all.

See http://wiki.openstreetmap.org/wiki/Key:payment and the JOSM preset.

comment:2 Changed 4 years ago by mdk

Is there a possibility to give the mapper a more helpful hint than Value 'yes' for key 'payment:credit_cards' not in preset.? Somethink like: Use more detailed 'payment:<credit card>' keys instead! and perhaps - let me dream - a link to the wiki :-)

comment:3 in reply to:  2 ; Changed 4 years ago by Klumbumbus

Replying to mdk:

Is there a possibility to give the mapper a more helpful hint than Value 'yes' for key 'payment:credit_cards' not in preset.? Somethink like: Use more detailed 'payment:<credit card>' keys instead! and perhaps - let me dream - a link to the wiki :-)

This is the default info which is reported for all keys, which are not in the preset. Remember this is only info level, not warning. However we could add an additional warning for payment:credit_cards=yes. But the above info message will stay there.

Last edited 4 years ago by Klumbumbus (previous) (diff)

comment:4 in reply to:  3 Changed 4 years ago by anonymous

Replying to Klumbumbus:

This is the default info which is reported for all keys, which are not in the preset. Remember this is only info level, not warning. However we could add an additional warning for payment:credit_cards=yes. But the above info message will stay there.

I think this would be helpful. If the mapper fixes the warning, the "cryptic" info will also disapear - mission accomplished.

comment:5 Changed 4 years ago by mdk

Sorry last comment was mine.

comment:6 Changed 4 years ago by Klumbumbus

Milestone: 15.06

comment:7 Changed 4 years ago by Don-vip

Milestone: 15.0615.07

skip milestone 15.06

comment:8 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8546/josm:

fix #11499 - add warning for inaccurate payment values.

comment:9 Changed 4 years ago by Don-vip

Milestone: 15.0715.08

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.