Wrong validator result: Value 'yes' for key 'payment:credit_cards' not in preset.

[mdk]

The node 1589860488 contains three payment types:

payment:cash=yes
payment:credit_cards=yes
payment:telephone_cards=yes

But only for payment:credit_cards the value 'yes' is unknown (the key itself is known)!

[Klumbumbus]

This is because payment:credit_cards=yes is not helpful information. You should use payment:mastercard=yes or payment:visa=yes, or ...

You can use payment:credit_cards=no to indicate that there are no credit cards accepted at all.

See ​http://wiki.openstreetmap.org/wiki/Key:payment and the JOSM preset.

[mdk]

Is there a possibility to give the mapper a more helpful hint than Value 'yes' for key 'payment:credit_cards' not in preset.? Somethink like: Use more detailed 'payment:<credit card>' keys instead! and perhaps - let me dream - a link to the wiki :-)

[Klumbumbus]

Replying to mdk:

Is there a possibility to give the mapper a more helpful hint than Value 'yes' for key 'payment:credit_cards' not in preset.? Somethink like: Use more detailed 'payment:<credit card>' keys instead! and perhaps - let me dream - a link to the wiki :-)

This is the default info which is reported for all keys, which are not in the preset. Remember this is only info level, not warning. However we could add an additional warning for payment:credit_cards=yes. But the above info message will stay there.

[anonymous]

Replying to Klumbumbus:

This is the default info which is reported for all keys, which are not in the preset. Remember this is only info level, not warning. However we could add an additional warning for payment:credit_cards=yes. But the above info message will stay there.

I think this would be helpful. If the mapper fixes the warning, the "cryptic" info will also disapear - mission accomplished.

[mdk]

Sorry last comment was mine.

[Don-vip]

skip milestone 15.06

[Klumbumbus]

In 8546/josm:

fix #11499 - add warning for inaccurate payment values.

[Don-vip]

Milestone renamed

[simon04]

In 17851/josm:

fix #20817, see #11499 - Validator: "payment:credit_cards=yes is inaccurate" as informational warning (patch by mkoniecz)

[Klumbumbus]

In 18557/josm:

fix #22367, see #11499 - Don't warn anymore about payment:credit_cards=yes and payment:debit_cards=yes, Reduce warning of payment:electronic_purses=yes and payment:cryptocurrencies=yes to info level

[aceman]

Well, according to the wiki payment:credit_cards=yes is a proper value meaning "common cards used in the region". So there is no need to somehow warn about it or deprecate it.
​https://wiki.openstreetmap.org/wiki/Key:payment:*

[Klumbumbus]

Replying to aceman:

So there is no need to somehow warn about it or deprecate it.

That's what was done in r18557.