Modify

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#19439 closed defect (fixed)

Test failing on shop=trade

Reported by: Stereo Owned by: team
Priority: normal Milestone: 20.06
Component: Unit tests Version:
Keywords: Cc: Klumbumbus

Description (last modified by Stereo)

This test is failing since https://josm.openstreetmap.de/changeset/16714/josm, which added shop=trade to the presets:

Testcase: org.openstreetmap.josm.data.validation.tests.TagCheckerTest

java.lang.AssertionError: [shop=trade]
	at org.openstreetmap.josm.data.validation.tests.TagCheckerTest.testIgnoredTagsNotInPresets(TagCheckerTest.java:208)
	at org.openstreetmap.josm.testutils.JOSMTestRules$TimeoutThread.run(JOSMTestRules.java:765)

This is because resources/data/validator/ignoretags.cfg has K:shop=trade on line 319.

See also #18265 for why shop=trade was added.

For the full test run, see https://github.com/grischard/josm/runs/808886749?check_suite_focus=true -> Java 8 on ubuntu-latest with headless=true

Attachments (0)

Change History (3)

comment:1 Changed 10 months ago by Stereo

Description: modified (diff)

comment:2 Changed 10 months ago by Klumbumbus

Milestone: 20.06
Resolution: fixed
Status: newclosed

This was already fixed with r16717.

comment:3 Changed 10 months ago by Stereo

Aha! My bad. I've rebased my fork, thank you.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.