Modify ↓

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#19439 closed defect (fixed)

Test failing on shop=trade

Reported by: Stereo Owned by: team
Priority: normal Milestone: 20.06
Component: Unit tests Version:
Keywords: Cc: Klumbumbus

Description (last modified by Stereo)

This test is failing since https://josm.openstreetmap.de/changeset/16714/josm, which added shop=trade to the presets:

Testcase: org.openstreetmap.josm.data.validation.tests.TagCheckerTest

java.lang.AssertionError: [shop=trade]
	at org.openstreetmap.josm.data.validation.tests.TagCheckerTest.testIgnoredTagsNotInPresets(TagCheckerTest.java:208)
	at org.openstreetmap.josm.testutils.JOSMTestRules$TimeoutThread.run(JOSMTestRules.java:765)

This is because resources/data/validator/ignoretags.cfg has K:shop=trade on line 319.

See also #18265 for why shop=trade was added.

For the full test run, see ​https://github.com/grischard/josm/runs/808886749?check_suite_focus=true -> Java 8 on ubuntu-latest with headless=true

Attachments (0)

Change History (3)

comment:1 by Stereo, 5 years ago

Description: modified (diff)

comment:2 by Klumbumbus, 5 years ago

Milestone: → 20.06
Resolution: → fixed
Status: new → closed

This was already fixed with r16717.

comment:3 by Stereo, 5 years ago

Aha! My bad. I've rebased my fork, thank you.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.