Modify

Opened 16 months ago

Closed 8 months ago

Last modified 8 months ago

#18265 closed enhancement (fixed)

add shops lighting, pest_control & security

Reported by: francians Owned by: Klumbumbus
Priority: normal Milestone: 20.06
Component: Internal preset Version:
Keywords: template_report shop lighting security pest_control Cc:

Attachments (3)

preset.patch (3.4 KB) - added by francians 16 months ago.
Schermata da 2020-05-03 18-04-20.png (126.3 KB) - added by francians 10 months ago.
Schermata da 2020-05-03 18-24-27.png (131.4 KB) - added by francians 10 months ago.

Download all attachments as: .zip

Change History (24)

Changed 16 months ago by francians

Attachment: preset.patch added

comment:1 Changed 16 months ago by Don-vip

Keywords: shop lighting security pest_control added

comment:2 Changed 10 months ago by francians

Hello,

any chance to see this ticket closed?

I have some more to suggest like: shop=printer_ink, shop=pottery or shop=trade (with trade=*).

How do you evaluate which tags to add to JOSM presets?

Thanks
Francesco

comment:3 Changed 10 months ago by Klumbumbus

The guidelines are here: wiki:/DevelopersGuide/DefaultPresets
Pest control has a very low usage (54 objects), I wouldn't add it for now.
Did you test the icons at 16px? I guess they are not recognizable at this size.

comment:4 in reply to:  3 Changed 10 months ago by francians

Replying to Klumbumbus:

The guidelines are here: wiki:/DevelopersGuide/DefaultPresets
Pest control has a very low usage (54 objects), I wouldn't add it for now.
Did you test the icons at 16px? I guess they are not recognizable at this size.

Right. Maybe this could be a good one:

https://publicdomainvectors.org/en/free-clipart/Yellow-lamp-shade/61718.html

please find in attachment the test I did and let me know.

Francesco

Changed 10 months ago by francians

comment:5 Changed 10 months ago by francians

And in case you like them please also accept these suggestions:

https://publicdomainvectors.org/en/free-clipart/Cooking-pot/42157.html
https://publicdomainvectors.org/en/free-clipart/Vector-clip-art-of-printer-color-icon/28131.html
https://openclipart.org/detail/312240/forklift

for shop=trade this could be added:

<chunk id="trade">

<combo key="trade" text="Trades" values="agricultural_supplies,building_supplies,catering_supplies,plumbing,tiles,timber,windows" />

</chunk>

Cheers
Francesco

Changed 10 months ago by francians

comment:6 Changed 9 months ago by Klumbumbus

Milestone: 20.06

comment:7 Changed 8 months ago by Klumbumbus

Owner: changed from team to Klumbumbus

comment:9 Changed 8 months ago by francians

Many thanks!
May I also suggest:

https://wiki.openstreetmap.org/wiki/Tag:shop%3Dwholesale

If it's common enough?
You can keep the same icon of trade...
Cheers
Francesco

comment:10 Changed 8 months ago by Klumbumbus

Ok, but everything should have its own icon. We can use the forklift for trade and the one from carto for wholesale.

comment:11 Changed 8 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 16714/josm:

fix #18265 - Add shop=lighting, shop=security, shop=wholesale and shop=trade (icons from https://publicdomainvectors.org/en/free-clipart/Yellow-lamp-shade/61718.html, https://publicdomainvectors.org/en/free-clipart/Alarm-system/75822.html, https://wiki.openstreetmap.org/wiki/File:Trade-14.svg and https://openclipart.org/detail/312240/forklift, all except wholesale modified, all PD and CC0 licensed), thanks to francians, deprecate shop=lamps

comment:12 Changed 8 months ago by Klumbumbus

In 16715/josm:

see #18265 - Add shop=pottery (icon is internal craft=pottery icon in shop color, PD and CC0 licensed)

comment:13 Changed 8 months ago by skyper

In my understanding, wholesale and trade should be <multiselect> instead of <combo>.

comment:14 Changed 8 months ago by Klumbumbus

There are very few tagged with multiple values. And the wiki doesn't mention it either. I don't want to introduce multiple values if not absolutely needed.

comment:15 Changed 8 months ago by Klumbumbus

In 16717/josm:

see #18265 - Fix always forgotten ignores file

comment:16 Changed 8 months ago by skyper

The presets just offers options. The user itself is still responsible about using one or multiple values which does not depend on the type of presentation.

There are no presets absolutely needed. Need usually depends on the point of view. From a user's perspective, current situation restricts my freedom of choice and hides the information that more than one value might be possible. It is also not working nicely if you hit objects with multiple values.

comment:17 in reply to:  8 Changed 8 months ago by francians

Replying to Klumbumbus:

https://wiki.openstreetmap.org/wiki/Tag:shop=pest_control Usage too low. You can add it to wiki:/Presets/NewTags if you want.

Done! Hope it's fine

comment:18 Changed 8 months ago by Klumbumbus

Looks good.

comment:19 Changed 8 months ago by aceman

Thanks for adding trade shop.
Why are there both 'timber' and 'wood'? What is the difference? Only timber is documented on the wiki. Yes, it is more popular on taginfo...

comment:20 Changed 8 months ago by Klumbumbus

I added the values from the wiki an when checking taginfo I noticed wood as popular value, so I added it but didn't notice the duplicate.

comment:21 Changed 8 months ago by Klumbumbus

In 16723/josm:

see #18265 - Remove trade=wood from preset (duplicate of timber)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.