add shops lighting, pest_control & security

[francians]

Hello,

please find the presets for:
​https://wiki.openstreetmap.org/wiki/Tag:shop%3Dlighting
​https://wiki.openstreetmap.org/wiki/Tag:shop%3Dsecurity
​https://wiki.openstreetmap.org/wiki/Tag:shop%3Dpest_control

I'm sure they will be adopted more widely if you add them as JOSM preset.
These are italian translations:

lighting->illuminazione
security->sicurezza
pest_control->disinfestazione

and the icon links:
​https://publicdomainvectors.org/en/free-clipart/Floor-lamp-on/61695.html
​https://publicdomainvectors.org/en/free-clipart/Alarm-system/75822.html
​https://publicdomainvectors.org/en/free-clipart/Vector-image-of-an-ant/8109.html

[francians]

Hello,

any chance to see this ticket closed?

I have some more to suggest like: shop=printer_ink, shop=pottery or shop=trade (with trade=*).

How do you evaluate which tags to add to JOSM presets?

Thanks
Francesco

[Klumbumbus]

The guidelines are here: wiki:/DevelopersGuide/DefaultPresets
Pest control has a very low usage (54 objects), I wouldn't add it for now.
Did you test the icons at 16px? I guess they are not recognizable at this size.

[francians]

Replying to Klumbumbus:

The guidelines are here: wiki:/DevelopersGuide/DefaultPresets
Pest control has a very low usage (54 objects), I wouldn't add it for now.
Did you test the icons at 16px? I guess they are not recognizable at this size.

Right. Maybe this could be a good one:

​https://publicdomainvectors.org/en/free-clipart/Yellow-lamp-shade/61718.html

please find in attachment the test I did and let me know.

Francesco

[francians]

And in case you like them please also accept these suggestions:

​https://publicdomainvectors.org/en/free-clipart/Cooking-pot/42157.html
​https://publicdomainvectors.org/en/free-clipart/Vector-clip-art-of-printer-color-icon/28131.html
​https://openclipart.org/detail/312240/forklift

for shop=trade this could be added:

<chunk id="trade">

<combo key="trade" text="Trades" values="agricultural_supplies,building_supplies,catering_supplies,plumbing,tiles,timber,windows" />

</chunk>

Cheers
Francesco

[Klumbumbus]

​https://wiki.openstreetmap.org/wiki/Tag:shop=lighting To be added.
​​https://wiki.openstreetmap.org/wiki/Tag:shop=security To be added.
​​https://wiki.openstreetmap.org/wiki/Tag:shop=pest_control Usage too low. You can add it to wiki:/Presets/NewTags if you want.
​https://wiki.openstreetmap.org/wiki/Tag:shop=printer_ink Usage low and a warning on the wiki page.
​​https://wiki.openstreetmap.org/wiki/Tag:shop=pottery The icon does not fit. It is a metal pot.
​​https://wiki.openstreetmap.org/wiki/Tag:shop=trade To be added.

[francians]

Many thanks!
May I also suggest:

​https://wiki.openstreetmap.org/wiki/Tag:shop%3Dwholesale

If it's common enough?
You can keep the same icon of trade...
Cheers
Francesco

[Klumbumbus]

Ok, but everything should have its own icon. We can use the forklift for trade and the one from carto for wholesale.

[Klumbumbus]

In 16714/josm:

fix #18265 - Add shop=lighting, shop=security, shop=wholesale and shop=trade (icons from ​https://publicdomainvectors.org/en/free-clipart/Yellow-lamp-shade/61718.html, ​https://publicdomainvectors.org/en/free-clipart/Alarm-system/75822.html, ​https://wiki.openstreetmap.org/wiki/File:Trade-14.svg and ​https://openclipart.org/detail/312240/forklift, all except wholesale modified, all PD and CC0 licensed), thanks to francians, deprecate shop=lamps

[Klumbumbus]

In 16715/josm:

see #18265 - Add shop=pottery (icon is internal craft=pottery icon in shop color, PD and CC0 licensed)

[skyper]

In my understanding, wholesale and trade should be <multiselect> instead of <combo>.

[Klumbumbus]

There are very few tagged with multiple values. And the wiki doesn't mention it either. I don't want to introduce multiple values if not absolutely needed.

[Klumbumbus]

In 16717/josm:

see #18265 - Fix always forgotten ignores file

[skyper]

The presets just offers options. The user itself is still responsible about using one or multiple values which does not depend on the type of presentation.

There are no presets absolutely needed. Need usually depends on the point of view. From a user's perspective, current situation restricts my freedom of choice and hides the information that more than one value might be possible. It is also not working nicely if you hit objects with multiple values.

[francians]

Replying to Klumbumbus:

​​https://wiki.openstreetmap.org/wiki/Tag:shop=pest_control Usage too low. You can add it to wiki:/Presets/NewTags if you want.

Done! Hope it's fine

[Klumbumbus]

Looks good.

[aceman]

Thanks for adding trade shop.
Why are there both 'timber' and 'wood'? What is the difference? Only timber is documented on the wiki. Yes, it is more popular on taginfo...

[Klumbumbus]

I added the values from the wiki an when checking taginfo I noticed wood as popular value, so I added it but didn't notice the duplicate.

[Klumbumbus]

In 16723/josm:

see #18265 - Remove trade=wood from preset (duplicate of timber)