Modify

Opened 2 months ago

Last modified 3 weeks ago

#19370 new task

Enable GitHub Actions

Reported by: simon04 Owned by: team
Priority: normal Milestone: Longterm
Component: Unit tests Version:
Keywords: github ci Cc: Stereo

Attachments (1)

test-failure-error-macOS.tar.xz (39.1 KB) - added by Stereo 2 months ago.
Test failing on my Mac

Download all attachments as: .zip

Change History (15)

comment:1 Changed 2 months ago by simon04

Everything except for ubuntu-latest with headless=true fails: https://github.com/openstreetmap/josm/actions/runs/132213807

comment:2 Changed 2 months ago by simon04

Owner: changed from simon04 to team
Status: assignednew

comment:3 Changed 2 months ago by Stereo

Really interesting, thank you! Both macOS and windows seem to fail on very similar things, and some of those do seem to be actual bugs.

I can't commit to that PR, so working on it will certainly get a bit tedious. How should we do it?

comment:4 Changed 2 months ago by Stereo

It also looks like the non-headless tests could run on macOS if we want them to.

comment:5 Changed 2 months ago by Stereo

To make the github action faster, we can use the cache action to cache ~/.ivy2/cache/ to keep these:

extract-libraries:
    [unzip] Expanding: /Users/stereo/.ivy2/cache/ch.poole/OpeningHoursParser/jars/OpeningHoursParser-0.21.4.jar into /Users/stereo/Documents/code/josm/build
    [unzip] Expanding: /Users/stereo/.ivy2/cache/com.adobe.xmp/xmpcore/jars/xmpcore-6.1.10.jar into /Users/stereo/Documents/code/josm/build
    [unzip] Expanding: /Users/stereo/.ivy2/cache/com.drewnoakes/metadata-extractor/jars/metadata-extractor-2.13.0.jar into /Users/stereo/Documents/code/josm/build
    [unzip] Expanding: /Users/stereo/.ivy2/cache/javax.json/javax.json-api/bundles/javax.json-api-1.1.4.jar into /Users/stereo/Documents/code/josm/build
    [unzip] Expanding: /Users/stereo/.ivy2/cache/oauth.signpost/signpost-core/jars/signpost-core-2.0.0.jar into /Users/stereo/Documents/code/josm/build
    [unzip] Expanding: /Users/stereo/.ivy2/cache/org.apache.commons/commons-compress/jars/commons-compress-1.20.jar into /Users/stereo/Documents/code/josm/build
    [unzip] Expanding: /Users/stereo/.ivy2/cache/org.apache.commons/commons-jcs3-core/jars/commons-jcs3-core-3.0-SNAPSHOT.jar into /Users/stereo/Documents/code/josm/build
    [unzip] Expanding: /Users/stereo/.ivy2/cache/org.glassfish/javax.json/bundles/javax.json-1.1.4.jar into /Users/stereo/Documents/code/josm/build
    [unzip] Expanding: /Users/stereo/.ivy2/cache/org.openstreetmap.jmapviewer/jmapviewer/jars/jmapviewer-2.14.jar into /Users/stereo/Documents/code/josm/build
    [unzip] Expanding: /Users/stereo/.ivy2/cache/org.tukaani/xz/jars/xz-1.8.jar into /Users/stereo/Documents/code/josm/build
    [unzip] Expanding: /Users/stereo/.ivy2/cache/org.webjars.npm/tag2link/jars/tag2link-2020.5.16.jar into /Users/stereo/Documents/code/josm/build

Changed 2 months ago by Stereo

Test failing on my Mac

comment:6 in reply to:  3 ; Changed 8 weeks ago by simon04

Replying to Stereo:

I can't commit to that PR, so working on it will certainly get a bit tedious. How should we do it?

Can you open a new pull request (starting from a branch of your JOSM fork)? If you allow "edits from maintainers", we both can work on that PR.

comment:7 Changed 8 weeks ago by simon04

Test failing on my Mac – attachment:test-failure-error-macOS.tar.xz

A bunch of the failures seem to be related to the used locale (en_US vs. en_?). This causes various strings to differ.

comment:8 Changed 7 weeks ago by simon04

Milestone: 20.06Longterm

comment:9 in reply to:  6 Changed 7 weeks ago by Stereo

Replying to simon04:

Replying to Stereo:

I can't commit to that PR, so working on it will certainly get a bit tedious. How should we do it?

Can you open a new pull request (starting from a branch of your JOSM fork)? If you allow "edits from maintainers", we both can work on that PR.

I've opened https://github.com/openstreetmap/josm/pull/60.

I've also messaged you on Matrix to make it easier to work together, but am also on Telegram and the OSMF US Slack if you'd like.

comment:10 Changed 4 weeks ago by simon04

In 16776/josm:

see #19370, see #18319 - Enable GitHub Actions and package for macOS (patch by Stereo and thomersch)

comment:11 Changed 4 weeks ago by Stereo

Cool!

The whole JOSM.app in native is now unnecessary, and can be deleted.

Now the next step should be changing the release mechanism to use this too - otherwise the August build won't be created.

Then we should change the script so that it still can still build and uploads an unsigned .app if it doesn't have the necessary secrets in the environment variables.

After that, it could be to fix the unit tests, and tell github to only build JOSM.app if the tests pass.

Finally, it could be finding a way of avoiding the way github will produce josm.zip.zip, which is https://github.com/actions/upload-artifact/issues/39

Last edited 4 weeks ago by Stereo (previous) (diff)

comment:12 Changed 3 weeks ago by simon04

In 16785/josm:

see #19370, see #18319 - native/macosx/JOSM.app/Contents/Resources/JOSM.icns (used by Ant)

comment:13 Changed 3 weeks ago by GerdP

Seems the changes in r16776 cause problem with Jenkins build?
https://josm.openstreetmap.de/jenkins/job/JOSM/jdk=JDK8/6625/console

comment:14 Changed 3 weeks ago by simon04

In 16786/josm:

see #19370, see #18319 - native/macosx/JOSM.app/Contents/Info.plist_template.xml (used by Ant)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to simon04
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.