Modify

Opened 7 weeks ago

Last modified 3 days ago

#19241 new defect

Why does "JOSM Validator" is a data source on upload?

Reported by: mdk Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report upload obtain source validator Cc: tomasmarklund

Description

What steps will reproduce the problem?

  1. Activate an imagery layer.
  2. Make some (faulty) edits
  3. validate (be sure validation errors are shown)
  4. start upload
  5. obtain source from current layers

What is the expected result?

The actual imagery layer is shown as data source.

What happens instead?

The actual imagery layer plus "JOSM Validator" is shown as data source.

Please provide any additional information below. Attach a screenshot if possible.

I didn't expect "JOSM Validator" as a data source.
If all layers are used for *data source", there may be other layers, which also make so sense.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-05-12 23:18:17 +0200 (Tue, 12 May 2020)
Revision:16403
Build-Date:2020-05-13 01:30:49
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (16403 en) Linux Ubuntu 20.04 LTS
Memory Usage: 477 MB / 1980 MB (118 MB allocated, but free)
Java version: 11.0.7+10-post-Ubuntu-3ubuntu1, Ubuntu, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-11-jre:amd64-11.0.7+10-3ubuntu1
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-compress-java: libcommons-compress-java:all-1.19-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
VM arguments: [--add-modules=java.scripting,java.sql, -Djosm.restart=true, -Djosm.dir.name=JOSM-latest, -Djava.net.useSystemProxies=true]

Plugins:
+ ColumbusCSV (35405)
+ FastDraw (35405)
+ HouseNumberTaggingTool (35248)
+ OpeningHoursEditor (35414)
+ RoadSigns (35424)
+ SimplifyArea (35405)
+ buildings_tools (35405)
+ contourmerge (v0.1.6)
+ imagery-xml-bounds (35313)
+ imagery_offset_db (35405)
+ pbf (35446)
+ poly (35248)
+ public_transport (35405)
+ reltoolbox (35405)
+ reverter (35409)
+ terracer (35327)
+ turnrestrictions (35405)
+ utilsplugin2 (35440)
+ wikipedia (1.1.4)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&preset&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&style&zip=1

Attachments (0)

Change History (7)

comment:1 Changed 7 weeks ago by skyper

It is source not imagery_used, e.g. we have Notes, JOSM Validator, Survey for gpx and the imagery names.
It is the user's job to have the correct layers active and to check the automatically included values.

comment:2 Changed 7 weeks ago by simon04

More than 9000 changesets use "JOSM validator" in their source tag according to osmcha

https://osmcha.org/?filters={"source"%3A[{"label"%3A"JOSM validator"%2C"value"%3A"JOSM validator"}]}

I'd consider setting "JOSM validator" only adequate when a massive amount of validator autofixes have been applied. Not, if a (maybe unrelated) error has been reported when uploading.

comment:3 Changed 7 weeks ago by mdk

The problem from options like "Automatically obtain source from current layers" is, that people tend to "forget" to check the result. Before upload I normally run the validator manually. In the most time, I get warnings,which are not from my (actual) edits and which I can't (or won't) fix right now. But now I have to think of closing the Validator layer before upload or manually edit the "data source" to prevent "JOSM Validator" to be in the sources string. I pretty sure, that the very most of the 9000 changesets found above are created with JOSM and after introducing this new feature.
In my opinion that is similar to automatically adding "Source=<Layer>" to new objects in the past (I don't know which editor or preset was responsible for that).

comment:4 Changed 7 weeks ago by skyper

What is the difference between a active imagery layer not used for edits and the validator layer? Note, that the validator run on upload is not taken into account.

I used validator/Validator before the changes.

The automatically include option seems to be the major problem and the small text box for source in the upload dialog which hides values once you have several "source" layers active.

comment:5 Changed 7 weeks ago by Klumbumbus

I don't include "JOSM validator" in my changeset source tags as I too don't consider it a "source".

comment:6 Changed 3 days ago by skyper

Ticket #19471 has been marked as a duplicate of this ticket.

comment:7 Changed 3 days ago by skyper

Cc: tomasmarklund added
Keywords: upload obtain source validator added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to mdk
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.