Modify

Opened 4 months ago

Closed 4 weeks ago

#19094 closed enhancement (fixed)

[Patch] Warning about "placement:forward/backward=transition"

Reported by: skyper Owned by: team
Priority: normal Milestone: 20.07
Component: Core validator Version:
Keywords: lanes-tagging placement transition Cc:

Description (last modified by skyper)

What steps will reproduce the problem?

  1. Have a way with placement:forward/backward=transition
  2. Run validator

What is the expected result?

A warning suggesting to use placement=transition

What happens instead?

No informational warning

Please provide any additional information below. Attach a screenshot if possible.

There is no need to use forward/backward with transition but it does not really harm. Still tagging scheme would be more consistent if only placement=transition would be used.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-13 22:05:56 +0200 (Mon, 13 Apr 2020)
Revision:16294
Build-Date:2020-04-14 01:30:47
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (1)

josm_19094.patch (2.3 KB) - added by skyper 4 weeks ago.
patch including warnings about multiple use and transition with placement:*

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 weeks ago by skyper

Oh, I see, there is no warning about multiple occurrences of placement[:forward/backward/both_ways]. This needs to be an error.

Changed 4 weeks ago by skyper

Attachment: josm_19094.patch added

patch including warnings about multiple use and transition with placement:*

comment:2 Changed 4 weeks ago by skyper

Find attached patch josm_19094.patch which adds warnings for both issues

  • Warning about transition as values of placement:*
  • Error for multiple use of placement[:*]

comment:3 Changed 4 weeks ago by skyper

Description: modified (diff)
Priority: minornormal
Summary: Informational warning about "placement:forward/backward=transition"[Patch] Warning about "placement:forward/backward=transition"

comment:4 Changed 4 weeks ago by skyper

Once #19511 is fixed, autofixes could be enabled for all cases of transition as value of placement:* even with some different values for other placement:*.

comment:5 Changed 4 weeks ago by Klumbumbus

Milestone: 20.07

comment:6 Changed 4 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 16778/josm:

fix #19094 - Warn about placement:forward/backward=transition (patch by skyper)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.