Modify ↓
Opened 6 years ago
Last modified 5 years ago
#18893 assigned enhancement
[Patch] OpeningHourTest highlight erroneous part in string
| Reported by: | simon04 | Owned by: | simon04 |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core validator | Version: | |
| Keywords: | opening_hours highlight | Cc: | skyper, SimonPoole |
Description
ticket:18892, skyper:
The messages should display the string with highlighted errors instead of the line and column
In JS, the messages displayed the string from the start to the position the error occurred but that does not work for multiple errors. See #18807
Attachments (2)
Change History (10)
by , 6 years ago
| Attachment: | 18893.patch added |
|---|
by , 6 years ago
| Attachment: | 2020-03-08-192958_783x158_scrot.png added |
|---|
comment:1 by , 6 years ago
| Cc: | added |
|---|---|
| Keywords: | highlight added |
comment:2 by , 6 years ago
Nice, but only highlight to the next separator e.g. space, comma or semi-colon.
comment:3 by , 6 years ago
| Milestone: | 20.03 → 20.04 |
|---|
comment:4 by , 6 years ago
| Milestone: | 20.04 → 20.05 |
|---|
comment:6 by , 6 years ago
| Milestone: | 20.05old → 20.05 |
|---|
comment:7 by , 6 years ago
| Milestone: | 20.05 → 20.06 |
|---|
comment:8 by , 5 years ago
| Milestone: | 20.06 |
|---|
Note:
See TracTickets
for help on using tickets.



Here's a draft, attachment:18893.patch
However, the highlighting is off by one token.
@SimonPoole, maybe we shouldn't be using
token.nextwhen creating aOpeningHoursParseExceptioninOpeningHoursParser.jj, but justtoken?