Modify

Opened 2 months ago

Last modified 6 weeks ago

#18680 new defect

Listener was not registered before: LayerChangeAdapter

Reported by: GerdP Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report regression Cc: Don-vip, Hb---

Description

What steps will reproduce the problem?

  1. Open History (Ctrl+H) for an element (doesn't seem to matter which one)
  2. Press Esc to close the history dialog
  3. Press F11 to switch to full screen mode

What is the expected result?

Switch to full screen mode

What happens instead?

Error popup

Please provide any additional information below. Attach a screenshot if possible.

When I close the layer F11 works as usual.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-02-01 01:10:57 +0100 (Sat, 01 Feb 2020)
Build-Date:2020-02-01 00:12:46
Revision:15806
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15806 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1903 (18362)
Memory Usage: 774 MB / 4551 MB (270 MB allocated, but free)
Java version: 1.8.0_221-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-XX:StartFlightRecording=name=MyRecording2,settings=d:\dbg\gerd.jfc, -XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true,dumponexitpath=e:\ld\perf_20200206_092533.jfr]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35250)
+ PolygonCutOut (v0.7)
+ apache-commons (35092)
+ buildings_tools (35248)
+ continuosDownload (91)
+ ejml (35122)
+ geotools (35169)
+ jaxb (35092)
+ jts (35122)
+ o5m (35248)
+ opendata (35313)
+ pbf (35248)
+ poly (35248)
+ reverter (35313)
+ undelete (35313)
+ utilsplugin2 (35248)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- E: Handled by bug report queue: java.lang.IllegalArgumentException: Listener was not registered before: LayerChangeAdapter [org.openstreetmap.josm.gui.history.VersionTable$ChangesetInfoAction@63f74c8f]


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (20) of main
java.lang.IllegalArgumentException: Listener was not registered before: LayerChangeAdapter [org.openstreetmap.josm.gui.history.VersionTable$ChangesetInfoAction@63f74c8f]
	at org.openstreetmap.josm.gui.layer.LayerManager.removeLayerChangeListener(LayerManager.java:433)
	at org.openstreetmap.josm.actions.JosmAction.destroy(JosmAction.java:275)
	at org.openstreetmap.josm.gui.history.VersionTable$VersionTablePopupMenu.destroy(VersionTable.java:258)
	at org.openstreetmap.josm.gui.history.VersionTable.destroy(VersionTable.java:110)
	at org.openstreetmap.josm.gui.util.GuiHelper.destroyComponents(GuiHelper.java:664)
	at org.openstreetmap.josm.gui.util.GuiHelper.destroyComponents(GuiHelper.java:660)
	at org.openstreetmap.josm.gui.util.GuiHelper.destroyComponents(GuiHelper.java:660)
	at org.openstreetmap.josm.gui.util.GuiHelper.destroyComponents(GuiHelper.java:660)
	at org.openstreetmap.josm.gui.util.GuiHelper.destroyComponents(GuiHelper.java:660)
	at org.openstreetmap.josm.gui.util.GuiHelper.destroyComponents(GuiHelper.java:660)
	at org.openstreetmap.josm.gui.util.GuiHelper.destroyComponents(GuiHelper.java:660)
	at org.openstreetmap.josm.gui.util.GuiHelper.destroyComponents(GuiHelper.java:660)
	at org.openstreetmap.josm.gui.util.GuiHelper.destroyComponents(GuiHelper.java:660)
	at org.openstreetmap.josm.gui.util.GuiHelper.destroyComponents(GuiHelper.java:660)
	at org.openstreetmap.josm.gui.history.HistoryBrowserDialog.dispose(HistoryBrowserDialog.java:199)
	at java.awt.Window.disposeImpl(Unknown Source)
	at java.awt.Window$1DisposeAction.run(Unknown Source)
	at java.awt.Window.doDispose(Unknown Source)
	at java.awt.Window.dispose(Unknown Source)
	at org.openstreetmap.josm.actions.FullscreenToggleAction.setMode(FullscreenToggleAction.java:84)
	at org.openstreetmap.josm.actions.FullscreenToggleAction.actionPerformed(FullscreenToggleAction.java:58)
	at javax.swing.SwingUtilities.notifyAction(Unknown Source)
	at javax.swing.JComponent.processKeyBinding(Unknown Source)
	at javax.swing.KeyboardManager.fireBinding(Unknown Source)
	at javax.swing.KeyboardManager.fireKeyboardAction(Unknown Source)
	at javax.swing.JComponent.processKeyBindingsForAllComponents(Unknown Source)
	at javax.swing.JComponent.processKeyBindings(Unknown Source)
	at javax.swing.JComponent.processKeyEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source)
	at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source)
	at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source)
	at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source)
	at java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

Attachments (0)

Change History (6)

comment:1 Changed 2 months ago by GerdP

Tested snapshots: r14460 was still ok, !14469 and later versions show the bug

comment:2 Changed 2 months ago by GerdP

Cc: Don-vip added

Regression from r14463?

comment:3 Changed 2 months ago by Don-vip

Keywords: regression added
Milestone: 20.02

Probably. I guess the dialog is destroyed twice with this scenario.

comment:4 Changed 7 weeks ago by GerdP

Ticket #18715 has been marked as a duplicate of this ticket.

comment:5 Changed 7 weeks ago by simon04

Cc: Hb--- added

comment:6 Changed 6 weeks ago by Don-vip

Milestone: 20.02

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to GerdP
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.