Modify

Opened 4 months ago

Last modified 2 months ago

#18673 new enhancement

Selection toggle dialog: Harmonize display of icons for "fixme" and "note"

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report selection toggle dialog fixme note icon Cc:

Description (last modified by stoecker)

What steps will reproduce the problem?

  1. Have six nodes, three with FIXME=* and three with note=*. First node of each group has no additional tag, the second node of each group has additionally an tag without icon like amenity=social_facility and the last node of each group has a tag with icon like amenity=atm. See attached file.
  2. Select all nodes
  3. Have a look at the icons in Selection toggle dialog

What is the expected result?

Somehow more harmonized icons like a big "N" or "F" for objects without any additional tag or tags without icons. Use only one color instead of black and red.

What happens instead?

A complete mixture:

  • No big "F" for only FIXME=* present
  • Really tiny, red "F" or "N" for tags without icons present

Please provide any additional information below. Attach a screenshot if possible.

mapview screenshot selection list screenshot

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-02-02 18:47:18 +0100 (Sun, 02 Feb 2020)
Revision:15810
Build-Date:2020-02-03 02:30:51
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (3)

josm_selection_screenshot.png (11.2 KB) - added by skyper 4 months ago.
selection list screenshot
josm_mapview_fixme_screenshot.png (1.6 KB) - added by skyper 4 months ago.
mapview screenshot
josm_selection_fixme_example.osm (1.1 KB) - added by skyper 4 months ago.
example file

Download all attachments as: .zip

Change History (15)

Changed 4 months ago by skyper

selection list screenshot

Changed 4 months ago by skyper

mapview screenshot

Changed 4 months ago by skyper

example file

comment:1 Changed 4 months ago by skyper

Description: modified (diff)

comment:2 Changed 4 months ago by Klumbumbus

for fixme use fixme not FIXME as key. That fixes the missing big F as there is no preset for FIXME just for fixme. Related: #17809

comment:3 Changed 4 months ago by stoecker

Description: modified (diff)

Align description and example.

comment:4 in reply to:  2 ; Changed 4 months ago by skyper

Replying to Klumbumbus:

for fixme use fixme not FIXME as key. That fixes the missing big F as there is no preset for FIXME just for fixme. Related: #17809

Nice spot, gonna upload a preset for FIXME. Noticed it, prior only in TagsMembership toggle dialog.

Anyway, using the small F is not a solution. Either show no icon (general object icon) or take care that the icon has the appropriate size.

comment:5 in reply to:  4 Changed 3 months ago by skyper

Replying to skyper:

Nice spot, gonna upload a preset for FIXME.

See Presets/FIXME?

Last edited 3 months ago by stoecker (previous) (diff)

comment:6 Changed 3 months ago by Klumbumbus

I'm against wiki:Presets/FIXME? as it supports the FIXME=* tag. The goal should be to get rid of it and use fixme=* only.

comment:7 in reply to:  6 ; Changed 2 months ago by skyper

Replying to Klumbumbus:

I'm against wiki:Presets/FIXME? as it supports the FIXME=* tag.

I can delete it from the JOSM page.

The goal should be to get rid of it and use fixme=* only.

Who says that? There was no global decision and the discussions never came to a conclusion. The wiki page mentions both usages.

iD does silently change it but I am against it. And if you look at the numbers of usage FIXME still rest at around 11% and is usually added by manual edits while fixme is often used in imports.

comment:8 in reply to:  7 ; Changed 2 months ago by stoecker

Replying to skyper:

The goal should be to get rid of it and use fixme=* only.

Who says that? There was no global decision and the discussions never came to a conclusion. The wiki page mentions both usages.

iD does silently change it but I am against it. And if you look at the numbers of usage FIXME still rest at around 11% and is usually added by manual edits while fixme is often used in imports.

JOSM does not always follow "global decision and the discussions". We simply do something (like replacing 3 variants of boolean with the yes/no standard we have now). Promoting different spelling for something is not a good idea. That makes automatic interpretation very hard.

comment:9 in reply to:  8 ; Changed 2 months ago by skyper

Replying to stoecker:

JOSM does not always follow "global decision and the discussions". We simply do something (like replacing 3 variants of boolean with the yes/no standard we have now).

That is a different story but is needed for #18929.

Promoting different spelling for something is not a good idea. That makes automatic interpretation very hard.

In general I go with you but I see it for some special keys and FIXME is special in my eyes. Plus JOSM supports it (almost) completely since I use it and in fact is missing in #12135.

Well, if you are still against it, on a JOSM page, I can move it or silently only use it locally.

comment:10 in reply to:  9 ; Changed 2 months ago by Klumbumbus

Replying to skyper:

only use it locally.

Yes, please. Supporting the use of a duplicate tag is worse than a missing icon in the selection list.

comment:11 in reply to:  10 ; Changed 2 months ago by skyper

I changed the page and removed the code. If you prefer to delete the page go ahead.

Replying to Klumbumbus:

Yes, please. Supporting the use of a duplicate tag is worse than a missing icon in the selection list.

The preset link in the Tags/Membership panel is missing, too.

Last edited 2 months ago by skyper (previous) (diff)

comment:12 in reply to:  11 Changed 2 months ago by Klumbumbus

Replying to skyper:

If you prefer to delete the page go ahead.

Someone else did alredy before my comment:10.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to skyper
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.