Modify

Opened 9 months ago

Closed 9 months ago

#18612 closed enhancement (fixed)

building=unclassified/unidentified/undefined/unknown/true/Y/* to building=yes autofix

Reported by: mkoniecz Owned by: Klumbumbus
Priority: minor Milestone: 20.01
Component: Core validator Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Create 4 closed areas
  2. Tag them with building=unclassified, building=unidentified, building=undefined, building=unknown, 3. Run validator

What is the expected result?

Validator proposes autofix to building=yes with description "building=yes is a standard tagging for building without specifying type of a construction"

What happens instead?

building=unclassified is not a building type. (1)
building=undefined is not a building type. (1)
building=unidentified is not a building type. (1)
building=unknown is not a building type. (1)

without autofix

Please provide any additional information below. Attach a screenshot if possible.

building=true, building=Y, building=* have an autofix

https://github.com/openstreetmap/iD/issues/7288 and https://josm.openstreetmap.de/ticket/17786#comment:4 are closely related

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-01-22 22:31:24 +0100 (Wed, 22 Jan 2020)
Revision:15752
Build-Date:2020-01-23 02:30:55
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (15752 en_GB) Linux Ubuntu 19.10
Memory Usage: 339 MB / 976 MB (53 MB allocated, but free)
Java version: 11.0.5+10-post-Ubuntu-0ubuntu1.1, Private Build, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-11-jre:amd64-11.0.5+10-0ubuntu1.1
Java ATK Wrapper package: libatk-wrapper-java:all-0.35.0-3
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ reverter (35248)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Region [WMTS_BLOCK_v2] Resetting cache
- E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=404
- E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=404
- E: Not Found - org.openstreetmap.josm.gui.widgets.HtmlPanel[,0,0,0x0,invalid,layout=java.awt.BorderLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=9,maximumSize=,minimumSize=,preferredSize=]

Attachments (0)

Change History (2)

comment:1 Changed 9 months ago by Klumbumbus

Milestone: 20.01
Owner: changed from team to Klumbumbus
Status: newassigned

comment:2 Changed 9 months ago by Klumbumbus

Resolution: fixed
Status: assignedclosed

In 15758/josm:

  • fix #18612 - autofix building=other|unclassified|undefined|unknown|unidentified to building=yes
  • fix #18603 - deprecate bicycle:oneway in favor of oneway:bicycle
  • fix #18605 - deprecate building:height and building:min_height in favor of height and min_height
  • fix #18607, see #18464 - fix validator rule text

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.