Modify

Opened 5 years ago

Closed 5 years ago

Last modified 17 months ago

#18606 closed defect (fixed)

Update roadsigns plugin with data for Belgium

Reported by: s8evq Owned by: bastiK
Priority: normal Milestone:
Component: Plugin roadsigns Version:
Keywords: belgium Cc: Klumbumbus

Description

Hello,

I have worked on the roadsigns plugin data for Belgium. I have updated the F-signs, after our wiki page has been updated (https://wiki.openstreetmap.org/wiki/Road_signs_in_Belgium#F_Direction_and_information_signs).

I also fixed some minor issues with the C-signs and changed the moped_a to mofa and moped_b to moped tagging, in accordance to the wiki.

Attachments (8)

roadsignpresetBE.xml (67.3 KB ) - added by s8evq 5 years ago.
BE_F118.png (9.2 KB ) - added by s8evq 5 years ago.
BE_F117.png (9.3 KB ) - added by s8evq 5 years ago.
BE_F99c.png (16.1 KB ) - added by s8evq 5 years ago.
BE_F99a.png (15.0 KB ) - added by s8evq 5 years ago.
BE_F51b.png (10.4 KB ) - added by s8evq 5 years ago.
BE_Type_IV_residents_exceptions_nl.png (21.8 KB ) - added by s8evq 5 years ago.
BE_Type_IV_residents_nl.png (15.7 KB ) - added by s8evq 5 years ago.

Download all attachments as: .zip

Change History (27)

by s8evq, 5 years ago

Attachment: roadsignpresetBE.xml added

by s8evq, 5 years ago

Attachment: BE_F118.png added

by s8evq, 5 years ago

Attachment: BE_F117.png added

by s8evq, 5 years ago

Attachment: BE_F99c.png added

by s8evq, 5 years ago

Attachment: BE_F99a.png added

by s8evq, 5 years ago

Attachment: BE_F51b.png added

by s8evq, 5 years ago

Attachment: BE_Type_IV_residents_nl.png added

comment:1 by Klumbumbus, 5 years ago

Are the icons PD or CC0 licensed?

comment:2 by anonymous, 5 years ago

They appeared in "Belgisch Staatsblad" / "Moniteur Belge" / "Belgisches Staatsblatt" (our Government Gazette https://en.wikipedia.org/wiki/Government_gazette). I assume that's public domain.

comment:3 by anonymous, 5 years ago

I downloaded them from our own wiki page: https://wiki.openstreetmap.org/wiki/Road_signs_in_Belgium

comment:4 by Don-vip, 5 years ago

Keywords: belgium added

comment:5 by s8evq, 5 years ago

Sorry for bumping this, but is more input required before merging these changes?

comment:6 by s8evq, 5 years ago

What would have to be done to get this plugin update, please?

comment:7 by Klumbumbus, 5 years ago

It's on my todo list, I'll have a look soon.

comment:8 by Klumbumbus, 5 years ago

There are two new icon errors. It can't load 'BE_F1a' and 'BE_F3a'.
I guess the files BE_F1.png and BE_F3.png should be renamed to BE_F1a.png and BE_F3a.png ?

comment:9 by Klumbumbus, 5 years ago

<sign ref="BE:ZONE" doesn't match with BE_zone.png, but is this entry useful at all? https://taginfo.openstreetmap.org/tags/traffic_sign=BE%3AZONE and https://taginfo.openstreetmap.org/tags/traffic_sign=BE%3Azone

comment:10 by Klumbumbus, 5 years ago

Resolution: fixed
Status: newclosed

Fixed in [o35416:35419], please check.

comment:11 by anonymous, 5 years ago

Thanks for looking into this. I must have missed the two new icons BE_F1a and BE_F3a....

Concerning BE:ZONE. This was something the previous person (jo polyglot) who made the initial xml files added. I didn't understand what it was for, so I didn't touch it. :)

comment:12 by Klumbumbus, 5 years ago

Yes BE:ZONE was an old bug, also the others from [o35417]. However if the zone entry doesn't make sense we can remove it from the xml. What do you think?

comment:13 by s8evq, 5 years ago

Yes, good idea. I will include it in the next set of update, when we overhaul the D-signs.

comment:14 by Klumbumbus, 5 years ago

OK

comment:15 by taylor.smock, 17 months ago

@s8evq: I'm currently working on converting the JOSM plugin repo to git (see #23286). Do you have a preferred name/email for that?

comment:16 by s8evq, 17 months ago

I don't have the time to be maintainer of this plugin, sorry.

comment:17 by taylor.smock, 17 months ago

I think we have a communication problem here. Probably my fault, sorry. I'll reword what I was trying to get at in comment:15.


What I would like to do as I'm converting the JOSM plugin repo to git from svn is to properly attribute patch authors as understood by git.

Example:
b5f17b86d795b677940a0e67c3b415e56fbd2d9b -- Warning: Link may become dead as I add more author information

commit b5f17b86d795b677940a0e67c3b415e56fbd2d9b
Author: s8evq <s8evq@fixme.todo>
Commit: Klumbumbus <Klumbumbus@users.noreply.github.com>

    see #josm18606 - Update Belgium data of roadsigns plugin (patch by s8evq), rename the files BE_F1.png and BE_F3.png to BE_F1a.png and BE_F3a.png

I'd like to have something besides s8evq@fixme.todo, especially if you are active on GitHub/GitLab/some other git forge, and would like to have the patches you worked on show up under your user profile (GitHub has a contributors page, for example).

comment:18 by s8evq, 17 months ago

Now I understand, thanks :)
I'm not really active on github or any other similar site. So I don't have a specific email I wish to use for that.

comment:19 by taylor.smock, 17 months ago

Fair enough. Sorry for bothering you.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain bastiK.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.