Modify ↓

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#18585 closed defect (fixed)

conditional tag: false positive

Reported by: skyper Owned by: Don-vip
Priority: normal Milestone: 20.01
Component: Core validator Version: latest
Keywords: template_report duration conditional Cc:

Description (last modified by skyper)

What steps will reproduce the problem?

  1. load attached file​
  2. run validator

What is the expected result?

No warning

What happens instead?

Wrong syntax in duration:conditional key (1)

Please provide any additional information below. Attach a screenshot if possible.

the warning gives no glue what could be wrong. I followed the wiki adding the conditional values:

<tag k='duration:conditional' v='00:15 @ (Mo-Fr 00:00-06:30,21:00-24:00; Sa 00:00-08:00,21:00-24:00; PH,Su 00:00-24:00)' />

Similar to #13651

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-01-20 01:16:42 +0100 (Mon, 20 Jan 2020)
Revision:15737
Build-Date:2020-01-20 02:30:59
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (1)

conditional_warning.osm​ (5.0 KB ) - added by skyper 6 years ago.
example file

Download all attachments as: .zip

Change History (9)

by skyper, 6 years ago

Attachment: conditional_warning.osm​ added

example file

comment:1 by Don-vip, 6 years ago

Description: modified (diff)

comment:2 by Don-vip, 6 years ago

Does it work without the PH clause?

in reply to:  2 comment:3 by skyper, 6 years ago

Replying to Don-vip:

Does it work without the PH clause?

No, does not change anything.

comment:4 by skyper, 6 years ago

Description: modified (diff)

comment:5 by Don-vip, 6 years ago

Milestone: → 20.01
Owner: changed from team to Don-vip
Status: new → assigned

comment:6 by Don-vip, 6 years ago

Keywords: duration added

comment:7 by Don-vip, 6 years ago

Resolution: → fixed
Status: assigned → closed

In 15743/josm:

fix #18585, see #17454 - Support duration as restriction-type in conditional syntax validator test

comment:8 by skyper, 6 years ago

The warning message for tags which are not supported by validator is still wrong. Please:

  • suppress the warning for unsupported tags

and/or

  • have a different warning about unusual combination

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.