Modify

Opened 9 months ago

Closed 9 months ago

Last modified 6 months ago

#18429 closed enhancement (fixed)

[RFC PATCH] Allow users to automatically get the source tags

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 19.12
Component: Core Version:
Keywords: upload changeset source Cc:

Description

Some people may use different sources for different uploads, and it would be nice if there was a way to automatically add source tags based off of current layers.

The source tag can still be modified.

What this patch currently does:

  • Adds a checkbox to automatically get the source tags
  • If checked, hides text to get the source tags just once
  • When unchecked, leave the current source

Attachments (2)

18429.patch (4.0 KB) - added by taylor.smock 9 months ago.
Add checkbox to automatically get source on every upload
18429.fix_auto.patch (1.3 KB) - added by taylor.smock 9 months ago.
Adds an ancestor listener that listens for the ancestorAdded call.

Download all attachments as: .zip

Change History (12)

Changed 9 months ago by taylor.smock

Attachment: 18429.patch added

Add checkbox to automatically get source on every upload

comment:1 Changed 9 months ago by Don-vip

Keywords: upload changeset source added
Milestone: 19.12

comment:2 Changed 9 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 15600/josm:

fix #18429 - Allow users to automatically get the source tags (patch by taylor.smock)

comment:3 Changed 9 months ago by taylor.smock

Resolution: fixed
Status: closedreopened

The patch in the current state just auto populates on the first open. I've modified the patch so that it works every time the window is opened.

Changed 9 months ago by taylor.smock

Attachment: 18429.fix_auto.patch added

Adds an ancestor listener that listens for the ancestorAdded call.

comment:4 Changed 9 months ago by taylor.smock

I probably should have indicated that I hadn't done significant testing yet, since I was uncertain if the wording I used was clear or not.

I had tested to make certain the toggle button worked inside the dialog, and on the initial dialog creation, but I hadn't tested consecutive uploads.

comment:5 Changed 9 months ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 15604/josm:

fix #18429 - Adds an ancestor listener that listens for the ancestorAdded call (patch by taylor.smock)

comment:6 Changed 9 months ago by Don-vip

Thanks!

comment:7 Changed 8 months ago by Klumbumbus

I don't really like it that I need to hit tab twice now to go from the comment to the source text box. What about switching the lines of the source text box and the auto check box?

comment:8 in reply to:  7 Changed 8 months ago by taylor.smock

Replying to Klumbumbus:

I don't really like it that I need to hit tab twice now to go from the comment to the source text box. What about switching the lines of the source text box and the auto check box?

I wouldn't mind doing this, but you might want to check out #18523 -- there are some UI problems I'm trying to track down (unsuccessfully), so I might file a patch that reverts the UI changes while keeping the logic, and just having people who want to get sources automatically go into advanced preferences to change it.

comment:9 Changed 8 months ago by simon04

In 15796/josm:

see #18429 - Upload dialog: put "just once" in parentheses

comment:10 Changed 6 months ago by Don-vip

In 16237/josm:

see #18429 - advanced preference upload.show.automatic.source to disable automatic source retrieval UI

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.