#18429 closed enhancement (fixed)
[RFC PATCH] Allow users to automatically get the source tags
| Reported by: | taylor.smock | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 19.12 |
| Component: | Core | Version: | |
| Keywords: | upload changeset source | Cc: |
Description
Some people may use different sources for different uploads, and it would be nice if there was a way to automatically add source tags based off of current layers.
The source tag can still be modified.
What this patch currently does:
- Adds a checkbox to automatically get the source tags
- If checked, hides text to get the source tags just once
- When unchecked, leave the current source
Attachments (2)
Change History (12)
by , 4 years ago
| Attachment: | 18429.patch added |
|---|
comment:1 by , 4 years ago
| Keywords: | upload changeset source added |
|---|---|
| Milestone: | → 19.12 |
comment:3 by , 4 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
The patch in the current state just auto populates on the first open. I've modified the patch so that it works every time the window is opened.
by , 4 years ago
| Attachment: | 18429.fix_auto.patch added |
|---|
Adds an ancestor listener that listens for the ancestorAdded call.
comment:4 by , 4 years ago
I probably should have indicated that I hadn't done significant testing yet, since I was uncertain if the wording I used was clear or not.
I had tested to make certain the toggle button worked inside the dialog, and on the initial dialog creation, but I hadn't tested consecutive uploads.
follow-up: 8 comment:7 by , 4 years ago
I don't really like it that I need to hit tab twice now to go from the comment to the source text box. What about switching the lines of the source text box and the auto check box?
comment:8 by , 4 years ago
Replying to Klumbumbus:
I don't really like it that I need to hit tab twice now to go from the comment to the source text box. What about switching the lines of the source text box and the auto check box?
I wouldn't mind doing this, but you might want to check out #18523 -- there are some UI problems I'm trying to track down (unsuccessfully), so I might file a patch that reverts the UI changes while keeping the logic, and just having people who want to get sources automatically go into advanced preferences to change it.
Add checkbox to automatically get source on every upload