Opened 4 years ago
Closed 4 years ago
#18428 closed enhancement (fixed)
[PATCH] Add `rapid` as a plugin that has been replaced by another plugin
Reported by: | taylor.smock | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | 19.12 |
Component: | Core | Version: | |
Keywords: | plugin, mapwithai, replace, rapid i18n | Cc: | stoecker |
Description
I've replaced the rapid
plugin with the MapWithAI
plugin.
In this patch, I also modified the code so that the common strings were abstracted out to separate string variables.
Attachments (3)
Change History (11)
by , 4 years ago
Attachment: | 18428.patch added |
---|
follow-up: 2 comment:1 by , 4 years ago
Cc: | added |
---|---|
Component: | Plugin → Core |
Keywords: | i18n added |
comment:2 by , 4 years ago
Replying to Don-vip:
I think this patch breaks the translation support.
I just tested it with a plugin renamed to osmarender
and rapid
.
I'll attach a screenshot.
by , 4 years ago
Attachment: | Screen Shot 2019-12-16 at 2.33.37 PM.png added |
---|
Screen shot of translated strings
follow-ups: 5 6 comment:3 by , 4 years ago
The translations will vanish as soon as this gets applied. Such a construct must use marktr() to specify translatable strings.
comment:4 by , 4 years ago
BTW: josm-geojson should be changed to inCore (makes no sense to reference another dead plugin).
comment:5 by , 4 years ago
Replying to stoecker:
The translations will vanish as soon as this gets applied. Such a construct must use marktr() to specify translatable strings.
OK. Just the one that is passed again to tr
? (replacedByPlugin
)
by , 4 years ago
Attachment: | 18428.1.patch added |
---|
Use marktr
for replacedByPlugin
and use inCore
for josm-geojson
comment:6 by , 4 years ago
I ran the localization script in i18n
, and all of the modified strings are in there with 18428.1.patch.
#: ../core/src/org/openstreetmap/josm/plugins/PluginHandler.java:93 msgid "integrated into main program" msgstr "" #: ../core/src/org/openstreetmap/josm/plugins/PluginHandler.java:94 #, java-format msgid "replaced by new {0} plugin" msgstr "" #: ../core/src/org/openstreetmap/josm/plugins/PluginHandler.java:95 msgid "no longer required" msgstr ""
comment:7 by , 4 years ago
Milestone: | → 19.12 |
---|---|
Priority: | normal → minor |
I think this patch breaks the translation support.