Modify ↓

Opened 6 years ago

Closed 6 years ago

#18428 closed enhancement (fixed)

[PATCH] Add `rapid` as a plugin that has been replaced by another plugin

Reported by: taylor.smock Owned by: team
Priority: minor Milestone: 19.12
Component: Core Version:
Keywords: plugin, mapwithai, replace, rapid i18n Cc: stoecker

Description

I've replaced the rapid plugin with the MapWithAI plugin.

In this patch, I also modified the code so that the common strings were abstracted out to separate string variables.

Attachments (3)

18428.patch​ (5.6 KB ) - added by taylor.smock 6 years ago.
Screen Shot 2019-12-16 at 2.33.37 PM.png​ (127.5 KB ) - added by taylor.smock 6 years ago.
Screen shot of translated strings
18428.1.patch​ (5.9 KB ) - added by taylor.smock 6 years ago.
Use marktr for replacedByPlugin and use inCore for josm-geojson

Download all attachments as: .zip

Change History (11)

by taylor.smock, 6 years ago

Attachment: 18428.patch​ added

comment:1 by Don-vip, 6 years ago

Cc: stoecker added
Component: Plugin → Core
Keywords: i18n added

I think this patch breaks the translation support.

in reply to:  1 comment:2 by taylor.smock, 6 years ago

Replying to Don-vip:

I think this patch breaks the translation support.

I just tested it with a plugin renamed to osmarender and rapid.
I'll attach a screenshot.

by taylor.smock, 6 years ago

Attachment: Screen Shot 2019-12-16 at 2.33.37 PM.png​ added

Screen shot of translated strings

comment:3 by stoecker, 6 years ago

The translations will vanish as soon as this gets applied. Such a construct must use marktr() to specify translatable strings.

comment:4 by stoecker, 6 years ago

BTW: josm-geojson should be changed to inCore (makes no sense to reference another dead plugin).

in reply to:  3 comment:5 by taylor.smock, 6 years ago

Replying to stoecker:

The translations will vanish as soon as this gets applied. Such a construct must use marktr() to specify translatable strings.

OK. Just the one that is passed again to tr? (replacedByPlugin)

by taylor.smock, 6 years ago

Attachment: 18428.1.patch​ added

Use marktr for replacedByPlugin and use inCore for josm-geojson

in reply to:  3 comment:6 by taylor.smock, 6 years ago

I ran the localization script in i18n, and all of the modified strings are in there with 18428.1.patch.

#: ../core/src/org/openstreetmap/josm/plugins/PluginHandler.java:93
msgid "integrated into main program"
msgstr ""

#: ../core/src/org/openstreetmap/josm/plugins/PluginHandler.java:94
#, java-format
msgid "replaced by new {0} plugin"
msgstr ""

#: ../core/src/org/openstreetmap/josm/plugins/PluginHandler.java:95
msgid "no longer required"
msgstr ""

comment:7 by Don-vip, 6 years ago

Milestone: → 19.12
Priority: normal → minor

comment:8 by Don-vip, 6 years ago

Resolution: → fixed
Status: new → closed

In 15615/josm:

fix #18428 - mark rapid plugin as having been replaced by MapWithAI plugin (patch by taylor.smock)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.