On upload missing tag - natural=water without water shown for circular ways or relations tagged as water

[ftcat]

What steps will reproduce the problem?

1. Upload or validate ways tagged as water

What is the expected result?

No warning

What happens instead?

Warning missing tag - natural=water without water

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-12-01 23:10:15 +0100 (Sun, 01 Dec 2019)
Build-Date:2019-12-02 02:30:57
Revision:15553
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15553 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Home 1909 (18363)
Memory Usage: 929 MB / 1820 MB (186 MB allocated, but free)
Java version: 1.8.0_231-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1366x768
Maximum Screen Size: 1366x768
Dataset consistency test: No problems found

Plugins:
+ FastDraw (34977)
+ ImproveWay (29)
+ MovementAlert (1511141840)
+ ShapeTools (1240)
+ auto_tools (73)
+ editgpx (35221)
+ ext_tools (34988)
+ imagery_offset_db (34908)
+ poly (34991)
+ reverter (35226)
+ rex (53)
+ tageditor (34977)
+ turnlanes (35204)
+ turnlanes-tagging (281)
+ turnrestrictions (34977)
+ undelete (34977)
+ utilsplugin2 (35238)
+ wikipedia (1.1.3)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1
+ https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1
- https://github.com/igitov/forest-josm-style/archive/master.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Whitewater&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1

Last errors/warnings:
- W: java.net.UnknownHostException: ecn.t0.tiles.virtualearth.net
- W: java.net.UnknownHostException: ecn.t2.tiles.virtualearth.net
- W: java.net.UnknownHostException: ecn.t0.tiles.virtualearth.net
- W: java.net.UnknownHostException: ecn.t0.tiles.virtualearth.net
- W: java.net.UnknownHostException: ecn.t3.tiles.virtualearth.net
- W: java.net.UnknownHostException: ecn.t1.tiles.virtualearth.net
- W: java.net.UnknownHostException: ecn.t2.tiles.virtualearth.net
- W: java.net.UnknownHostException: ecn.t3.tiles.virtualearth.net
- W: java.net.UnknownHostException: ecn.t0.tiles.virtualearth.net
- W: java.net.UnknownHostException: ecn.t1.tiles.virtualearth.net

[GerdP]

This seems to be wanted, see #18297

[Klumbumbus]

Ticket #18400 has been marked as a duplicate of this ticket.

[Klumbumbus]

​osmwiki:Tag:natural=water says "The type of water body can be specified with water=*," and ​osmwiki:Key:water says for water=lake "This value should be considered default for natural=water, when no water or other descriptive tags are specified." So the water key is not mandatory and we should lower the warning to info level.

[Don-vip]

In 15568/josm:

fix #18394, see #18297 - reduce natural=water check level to info