Modify

Opened 10 days ago

Closed 9 days ago

Last modified 8 days ago

#18297 closed enhancement (fixed)

Invalidate natural=water with no other tags

Reported by: pangoSE Owned by: Don-vip
Priority: normal Milestone: 19.11
Component: Core validator Version:
Keywords: natural water Cc:

Description (last modified by Don-vip)

Hi
I think lakes only tagged with natural=water is wrong.
Could we add this to the validator?
In Västernorrland in Sweden alone I found ~1700 lakes missing the water=lake tag.

(FYI I did this:
natural=water and key!=waterway and key!=water in "västernorrland" <- overpass turbo wiz
"natural=water and -water=* and -waterway=* and (type:way or type:relation)" <- search in josm - I excluded nodes to avoid some incorrectly tagged bays near Sundsvall)

Attachments (0)

Change History (12)

comment:1 Changed 10 days ago by pangoSE

Description: modified (diff)

comment:2 Changed 10 days ago by pangoSE

Description: modified (diff)

comment:3 Changed 10 days ago by pangoSE

Description: modified (diff)

comment:4 Changed 9 days ago by Don-vip

Description: modified (diff)

comment:5 Changed 9 days ago by Don-vip

Keywords: natural water added
Milestone: 19.11
Owner: changed from team to Don-vip
Status: newassigned

comment:6 Changed 9 days ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 15512/josm:

fix #18297 - throw warning for natural=water without water

comment:7 Changed 9 days ago by Wulfmorn

But not all water is a lake...

comment:8 in reply to:  7 Changed 9 days ago by Klumbumbus

Replying to Wulfmorn:

But not all water is a lake...

There are other values of the key water available. It only warns if the key water is not set at all.

comment:9 Changed 9 days ago by Wulfmorn

Sorry, I was a bit quick because i had to run out to lunch :) I mean, this issue is about Sweden (the example), and in Sweden a small body of water is not a lake, its a "tjärn", which I believe is not a pond. You COULD map everything as lake, but I've always felt that there is something missing - same as with river/stream/ditch.

Anyway, I think this validation should also warn about too big ponds and too small lakes.

comment:10 Changed 8 days ago by pangoSE

@wulfmorn I disagree. The definition of a lake in osm is not determined by its size but by whether it is man made or not and whether it is open to the sea or not, etc. If you want all tjärn in sweden I suggest setting up a postgis environment and search by size or name.
The limit for when a tjärn becomes a lake is completely arbitrary and prone to subjective differences.

comment:11 Changed 8 days ago by Don-vip

This issue has nothing to do with lakes. As said we only check that natural=water has a water key. For tagging discussions, please don't use the JOSM bugtracker.

comment:12 Changed 8 days ago by pangoSE

See here for further discussion related to water tagging: https://www.openstreetmap.org/user/pangoSE/diary/391133

Last edited 8 days ago by pangoSE (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.