add shop=herbalist to presets

[mkoniecz]

What steps will reproduce the problem?

1. tag shop=herbalist node

What is the expected result?

it has an icon

What happens instead?

it has no icon

Please provide any additional information below. Attach a screenshot if possible.

​https://wiki.openstreetmap.org/wiki/Tag:shop%3Dherbalist

over 1k uses

See https://josm.openstreetmap.de/ticket/18310 for more background

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-11-17 21:16:26 +0100 (Sun, 17 Nov 2019)
Revision:15528
Build-Date:2019-11-18 02:30:59
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (15528 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 317 MB / 978 MB (146 MB allocated, but free)
Java version: 11.0.5+10-post-Ubuntu-2ubuntu116.04, Ubuntu, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-11-jre:amd64-11.0.5+10-2ubuntu1~16.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-6
libcommons-logging-java: libcommons-logging-java:all-1.2-1+build1
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ PicLayer (35104)
+ apache-commons (35092)
+ buildings_tools (35171)
+ continuosDownload (82)
+ ejml (35122)
+ geotools (35169)
+ imagery_offset_db (34908)
+ jts (35122)
+ log4j (34908)
+ measurement (35221)
+ reverter (35226)
+ todo (30306)

Validator rules:
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out

[Klumbumbus]

It would be great if you could add an icon. That would help a lot. Please see the requirements for new icons at wiki:/DevelopersGuide/DefaultPresets. (Same for the other tickets of this type.)

[Klumbumbus]

(I just added a new style which helps in testing icons: wiki:/Styles/IconTester)

[mkoniecz]

The license needs to be compatible with GPL3 (like PD or CC0)

Is CC-BY OK? ​https://fontawesome.com/license/free claims "GPL friendly", not sure whatever they are lying or whatever this linked doc can be amended.

iD is using ​https://fontawesome.com/icons/leaf?style=solid and it seems good fit, assuming that CC-BY is OK.

[Klumbumbus]

Replying to mkoniecz:

The license needs to be compatible with GPL3 (like PD or CC0)

Is CC-BY OK?

I'm not sure. So far I personally added only PD or CC0 icons to JOSM to avoid license issues.

[mkoniecz]

I heard arguments that legally icons or other images are not a part of the program. From my perspective "the GUI is not considered to be part of the program" is absurd, but supposedly it works legally.

According to this argument as long as distribution of images itself is not a copyright violation it can be used.

For example StreetComplete is using CC-BY artworks and photos in its interface.

See for example ​https://github.com/westnordost/StreetComplete/issues/154 where I attempted to check how it works, but as I am not a lawyer it basically went nowhere and went with "it appears that everyone is doing this, we are acting in a good faith, hopefully it will not go horrifically wrong".

[stoecker]

Replying to mkoniecz:

I heard arguments that legally icons or other images are not a part of the program. From my perspective "the GUI is not considered to be part of the program" is absurd, but supposedly it works legally.

According to this argument as long as distribution of images itself is not a copyright violation it can be used.

For example StreetComplete is using CC-BY artworks and photos in its interface.

See for example ​https://github.com/westnordost/StreetComplete/issues/154 where I attempted to check how it works, but as I am not a lawyer it basically went nowhere and went with "it appears that everyone is doing this, we are acting in a good faith, hopefully it will not go horrifically wrong".

I wouldn't test it. Simply take the idea and redraw an SVG without using the original icon. The basic idea of such a small icon alone cannot be protected as it is not significant enough to be protected art (only a larger collection of similar icons can be) and when redone without using the original license of whatever source does not have effect.

[anonymous]

Or take ​https://commons.wikimedia.org/wiki/File:Leaf_icon_(Noun_Project).svg from ​https://commons.wikimedia.org/wiki/Category:Leaf_icons

[mkoniecz]

That was me

[Klumbumbus]

In 17071/josm:

fix #18335 - Add shop=herbalist (icon from ​https://openclipart.org/detail/301781/coriander-leav, modified, PD and CC0 licensed)