Modify

Opened 3 years ago

Closed 3 years ago

#18334 closed enhancement (fixed)

Validator error for manhole=plain

Reported by: pyrog Owned by: team
Priority: normal Milestone: 19.11
Component: Core validator Version:
Keywords: template_report Cc:

Description

Validator display "Valeur de la propriété inconnue - La valeur 'plain' de la clé 'manhole' est inconnue, peut-être s'agit-il d'une des 'drain' ?"
way 623185031

The tag manhole=plain is documented in the [wiki https://wiki.openstreetmap.org/wiki/Key:manhole]

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-11-06 00:36:45 +0100 (Wed, 06 Nov 2019)
Build-Date:2019-11-06 02:30:56
Revision:15519
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15519 fr) Mac OS X 10.14.6
OS Build number: Mac OS X 10.14.6 (18G95)
Memory Usage: 995 MB / 1820 MB (444 MB allocated, but free)
Java version: 1.8.0_221-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69732928 1280x800
Maximum Screen Size: 1280x800
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/31/583aa85f-4a297e61, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Dmacosx.jnlpx.dock.name=JOSM (development version), -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/25/4c122699-72a21903.icns, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm-latest.jnlp , -Djnlpx.jvm="<java.home>/bin/java"]
Dataset consistency test: No problems found

Plugins:
+ CADTools (1008)
+ PicLayer (35104)
+ SeaMapEditor (34908)
+ apache-commons (35092)
+ apache-http (34908)
+ cadastre-fr (35194)
+ ejml (35122)
+ geotools (35169)
+ jaxb (35014)
+ jna (34908)
+ jts (35122)
+ opendata (35179)
+ reverter (35084)
+ tag2link (35149)
+ utilsplugin2 (35177)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Towers&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Telecom&zip=1

Validator rules:
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip
+ ${HOME}/Downloads/Rules_Pictures.validator.mapcss

Last errors/warnings:
- W: Identifiant de territoire inconnu: UK
- W: Identifiant de territoire inconnu: UK
- W: Identifiant de territoire inconnu: UK
- W: Identifiant de territoire inconnu: UK
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out

Attachments (0)

Change History (7)

comment:1 Changed 3 years ago by Klumbumbus

The value "plain" doesn't make sense, as the value of the key manhole describes to which "infrastructure" (gas, water,...) the manhole leads. If the cover has an inscription or not is independent from this. So we should better warn about man_hole=plain and suggest to use a better value.

comment:2 Changed 3 years ago by Klumbumbus

In 15530/josm:

see #18334, see #17947 - warn about manhole=unknown and manhole=plain

comment:3 Changed 3 years ago by Klumbumbus

Component: CoreCore validator
Milestone: 19.11
Type: defectenhancement

comment:4 Changed 3 years ago by pyrog

I understand that if there is no inscription on the cover, you couldn't know witch is the infrastructure below.
So that's explain the existence of this value.

comment:5 Changed 3 years ago by Klumbumbus

You could know from your local knowledge. If you don't know then you should simply ommit the key manhole=*.

comment:6 Changed 3 years ago by mdk

What is about mahole=yes (used 5758 times). This value also describes no infrastructure.

comment:7 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 15532/josm:

fix #18334, see #17947 - warn about manhole=yes and don't warn about manhole=plain looks like manhole=drain

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.