Modify

Opened 4 weeks ago

Closed 3 weeks ago

Last modified 103 minutes ago

#18310 closed enhancement (fixed)

add shop=weapons to presets

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 19.11
Component: Internal preset Version:
Keywords: template_report shop weapons Cc:

Description (last modified by mkoniecz)

What steps will reproduce the problem?

  1. tag shop=weapons node

What is the expected result?

it has an icon

What happens instead?

discover that it has no icon

Please provide any additional information below. Attach a screenshot if possible.

this tag is used over 1000 times and has a wiki page https://wiki.openstreetmap.org/wiki/Tag:shop%3Dweapons

https://josm.openstreetmap.de/query?status=assigned&status=closed&status=needinfo&status=new&status=reopened&keywords=~shop&order=priority found no relevant matches

https://josm.openstreetmap.de/query?status=assigned&status=closed&status=needinfo&status=new&status=reopened&keywords=~weapons&order=priority https://josm.openstreetmap.de/query?status=assigned&status=closed&status=needinfo&status=new&status=reopened&keywords=~weapons&order=priority found no matches

triggered by https://github.com/gravitystorm/openstreetmap-carto/pull/3730

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-11-06 07:17:52 +0100 (Wed, 06 Nov 2019)
Build-Date:2019-11-07 02:30:54
Revision:15520
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15520 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 314 MB / 869 MB (178 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
libcommons-logging-java: libcommons-logging-java:all-1.2-1+build1
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ PicLayer (35104)
+ apache-commons (35092)
+ buildings_tools (35171)
+ continuosDownload (82)
+ ejml (35122)
+ geotools (35169)
+ imagery_offset_db (34908)
+ jts (35122)
+ log4j (34908)
+ measurement (35221)
+ reverter (35226)
+ todo (30306)

Validator rules:
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

Attachments (2)

shop_values_appearing_over_1k_times.osm (10.4 KB) - added by mkoniecz 4 weeks ago.
test file with top shop values, I plan on reviewing all of them (so far shop=ice_cream triggered tagging mailing list thread and shop=weapons this issue, other are not reviewed)
shop_values.py (1005 bytes) - added by mkoniecz 4 weeks ago.
generator of osm file

Download all attachments as: .zip

Change History (9)

Changed 4 weeks ago by mkoniecz

test file with top shop values, I plan on reviewing all of them (so far shop=ice_cream triggered tagging mailing list thread and shop=weapons this issue, other are not reviewed)

Changed 4 weeks ago by mkoniecz

Attachment: shop_values.py added

generator of osm file

comment:1 Changed 4 weeks ago by mkoniecz

Description: modified (diff)

comment:2 Changed 4 weeks ago by mkoniecz

Description: modified (diff)

comment:3 Changed 4 weeks ago by Don-vip

Keywords: shop weapons added

comment:4 Changed 3 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 15528/josm:

comment:5 Changed 2 weeks ago by Don-vip

There's an icon warning:

https://josm.openstreetmap.de/jenkins/job/JOSM-Integration/3916/warnings4Result/NORMAL/

weapons.svg

ViewBox has float values: 0 0 14.999403 9.3749926

comment:6 Changed 2 weeks ago by Klumbumbus

In 15537/josm:

see #18310 - fix icon

comment:7 Changed 103 minutes ago by Don-vip

Milestone: 19.11

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.