[PATCH] Ask layers for source, don't hardcode source for layer types

[taylor.smock]

Initial patch. Adds getChangesetSourceTag to Layer class and overrides it in GpxLayer, ImageryLayer, and GeoImageLayer.

[taylor.smock]

Use streams to build the set (uses distinct to avoid duplicates)

[Don-vip]

the layer visibility condition is missing in the patch.

[taylor.smock]

Add checks for layer visibility

[taylor.smock]

Alternatively, the stream could be changed from layerManager.getLayers().stream() to layerManager.getVisibleLayersInZOrder().stream().

[taylor.smock]

Alternative method to 18160.2.patch for only getting visible layer changeset source comments

[Don-vip]

Nice!

[Don-vip]

In 15371/josm:

fix #18160 - Ask layers for source, don't hardcode source for layer types (patch by taylor.smock)

[Klumbumbus]

Has this any impact on end users?

[stoecker]

Not directly ;-)

[Don-vip]

No, it's just a much better way of coding this. It will have an impact however if some plugins define a "changeset source tag" for their custom layers. I could probably make use of the feature in the cadastre-fr and opendata plugins.

[taylor.smock]

It shouldn't have any direct impact. I actually filed the bug and patch because I wanted to report the source for a data layer for a plugin I'm working on. For that plugin, I should check and see if there is a way to tell if the layer has been uploaded since the plugin data was last used, so I can programmatically return null or the source from the plugin, to more accurately reflect the data usage.

I didn't see one in my quick grep through the source code, and if I can't find one that is being called on upload, I'll probably implement that as well.

[Klumbumbus]

Ok, I wasn't sure if something should be added to wiki:/Changelog.