Modify

Opened 2 years ago

Last modified 2 years ago

#18161 new enhancement

Enable drag&drop for plugin.jar, presets.xml, style.mapcss, rules.validator.mapcss

Reported by: simon04 Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: sotm19 drag&drop Cc:

Description (last modified by Don-vip)

The operations

  • drag&drop of a file onto JOSM
  • drag&drop of an URL onto JOSM
  • pasting a file from system clipboard inside JOSM

should install

  • plugins when the corresponding file is a plugin
  • style when the corresponding file is a MapCSS style
  • presets when the corresponding file is a preset XML file
  • validation rules when the corresponding file is a MapCSS validation rule set

Attachments (0)

Change History (5)

comment:1 Changed 2 years ago by stoecker

Hmm. I'm not sure that is a good idea. Drag&Drop for active components is a big security issue and the number of users of local styles, plugins, ... is extremely low.

comment:2 Changed 2 years ago by Don-vip

Description: modified (diff)

comment:3 Changed 2 years ago by Don-vip

Can you please describe why you think it's a security issue? Drag and drop can only occur locally, I don't see why it would be more dangerous to install extensions like this rather than downloading something from the Internet.

comment:4 Changed 2 years ago by stoecker

Normal behavior for Drag&Drop is to load a file and display it. This style of Drag&Drop does modify the configuration (in case of a plugin in a severe way).

The internet download has security implications as well, but it is a clearly defined way and more or less monitored by the community.

I agree that the risk is moderate, but the question is if there is a reason to introduce such an additional risk for the very limited number of users.

comment:5 Changed 2 years ago by Don-vip

Install by drag and drop is a common practice in several use cases:

I understand the goal as to offer people making extensions a very fast way to load them. I agree the target is limited but still it would be useful (especially for me when I must create a sample map style to reproduce an issue).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to simon04
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.