Modify

Opened 8 weeks ago

Closed 8 weeks ago

#18151 closed enhancement (fixed)

amenity=recycling without recycling:*=yes tag should trigger request to add data

Reported by: mkoniecz Owned by: Don-vip
Priority: minor Milestone: 19.09
Component: Core validator Version:
Keywords: template_report amenity recycling Cc:

Description (last modified by mkoniecz)

What steps will reproduce the problem?

  1. Create node
  2. Tag with amenity=recycling recycling_type=container
  3. Run validator
  4. Enable info level warnings

What is the expected result?

Validator complains that it is not specified what can be recycled there.

What happens instead?

Nothing.

Please provide any additional information below. Attach a screenshot if possible.

Not sure is it belonging at info or warning level, but it is at least as useful as detailed tagging of payment methods.

Inspired by https://github.com/westnordost/StreetComplete/issues/223

Example: https://www.openstreetmap.org/node/1937276244

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-09-12 23:23:47 +0200 (Thu, 12 Sep 2019)
Build-Date:2019-09-12 21:28:35
Revision:15348
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15348 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 315 MB / 869 MB (89 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
libcommons-logging-java: libcommons-logging-java:all-1.2-1+build1
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ PicLayer (35104)
+ buildings_tools (34982)
+ continuosDownload (82)
+ ejml (35049)
+ geotools (34908)
+ imagery_offset_db (34908)
+ jts (35064)
+ log4j (34908)
+ measurement (35051)
+ reverter (35084)
+ todo (30306)

Validator rules:
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: Failed to add ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss to tag checker
- W: java.nio.file.NoSuchFileException: ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
- W: Failed to add ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss to tag checker
- W: java.nio.file.NoSuchFileException: ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
- W: Failed to add ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss to tag checker
- W: java.nio.file.NoSuchFileException: ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss
- W: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- E: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- W: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- E: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition

Attachments (0)

Change History (4)

comment:1 Changed 8 weeks ago by mkoniecz

Description: modified (diff)

comment:2 Changed 8 weeks ago by Don-vip

Component: CoreCore validator
Keywords: amenity recycling added

comment:3 Changed 8 weeks ago by Don-vip

Milestone: 19.09
Owner: changed from team to Don-vip
Status: newassigned

comment:4 Changed 8 weeks ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 15360/josm:

fix #18151 - warning for amenity=recycling without recycling:*
fix #18152 - convert recycling:metal to recycling:scrap_metal

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.