Convert recycling:metal to recycling:scrap_metal

[mkoniecz]

What steps will reproduce the problem?

1. Create node
2. Tag it with recycling:metal=yes
3. Run validator

What is the expected result?

Validator offers to replace this tag with recycling:scrap_metal

What happens instead?

Presets do not contain property key - Key 'recycling:metal' not in presets. (1)

Please provide any additional information below. Attach a screenshot if possible.

According to ​https://taghistory.raifer.tech/ recycling:scrap_metal clearly dominates in use, is also less affected by imports.

recycling:green_waste with its duplicate recycling:garden_waste is the enxt candidate, but less obvious and may be worth discussing on @tagging.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-09-12 23:23:47 +0200 (Thu, 12 Sep 2019)
Build-Date:2019-09-12 21:28:35
Revision:15348
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15348 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 514 MB / 869 MB (203 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
libcommons-logging-java: libcommons-logging-java:all-1.2-1+build1
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ PicLayer (35104)
+ buildings_tools (34982)
+ continuosDownload (82)
+ ejml (35049)
+ geotools (34908)
+ imagery_offset_db (34908)
+ jts (35064)
+ log4j (34908)
+ measurement (35051)
+ reverter (35084)
+ todo (30306)

Validator rules:
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: Failed to add ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss to tag checker
- W: java.nio.file.NoSuchFileException: ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss
- W: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- E: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- W: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- E: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- W: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- E: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<You requested too many nodes (limit is 50000). Either request a smaller area, or use planet.osm>
- E: Bad Request - org.openstreetmap.josm.gui.widgets.HtmlPanel[,0,0,0x0,invalid,layout=java.awt.BorderLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=9,maximumSize=,minimumSize=,preferredSize=]

[Don-vip]

In 15360/josm:

fix #18151 - warning for amenity=recycling without recycling:*
fix #18152 - convert recycling:metal to recycling:scrap_metal

[marc_marc]

for the record, I asked the question on tagging (no answer yet at the time I post the url)
​https://lists.openstreetmap.org/pipermail/tagging/2019-December/049927.html