option to ignore validator warnings is missing to me

[mkoniecz]

What steps will reproduce the problem?

1. Run validator
2. Encounter "Incomplete pedestrian crossing tagging. Required tags are highway=crossing|traffic_signals and crossing=*. (4)"
3. Realize that I will fix once I walk there with StreetComplete and it is better to fix errors easier to fix with remote editing
4. Become confusing by missing ignore option that I am sure that was somewhere in validator list in earlier versions

What is the expected result?

I can ignore groups and specific errors easier to fix during survey or that I reported as bug already.

What happens instead?

No ability to ignore.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-09-12 23:23:47 +0200 (Thu, 12 Sep 2019)
Build-Date:2019-09-12 21:28:35
Revision:15348
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15348 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 389 MB / 869 MB (103 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
libcommons-logging-java: libcommons-logging-java:all-1.2-1+build1
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ PicLayer (35104)
+ buildings_tools (34982)
+ continuosDownload (82)
+ ejml (35049)
+ geotools (34908)
+ imagery_offset_db (34908)
+ jts (35064)
+ log4j (34908)
+ measurement (35051)
+ reverter (35084)
+ todo (30306)

Validator rules:
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: Failed to add ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss to tag checker
- W: java.nio.file.NoSuchFileException: ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
- W: Failed to add ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss to tag checker
- W: java.nio.file.NoSuchFileException: ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss
- W: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- E: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- W: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- E: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- W: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- E: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition

[Don-vip]

What's wrong with ignore button?

[mkoniecz]

It is not present in my JOSM.

Also, right-click used to be possible on groups (folders) like "Crossing buildings" - now it is available only for individual items.

I retested with

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-09-19 00:20:17 +0200 (Thu, 19 Sep 2019)
Build-Date:2019-09-19 01:30:57
Revision:15355
Relative:URL: ^/trunk

[Don-vip]

Did you set validator.ignore to false in the advanced preferences?

[mkoniecz]

I have it set in this way but I do not remember doing this and I never wanted to get rid of "ignore" dialog.

After flipping it and restart I got ignore interface back.

Thanks!

But I still have no idea how this setting flipped.

[Don-vip]

Strange. Reopen the issue if some JOSM feature or plugin accidentally disables this property.

[Klumbumbus]

Replying to mkoniecz:

But I still have no idea how this setting flipped.

It's the first check box in the preference settings. Maybe you accidently hit it when you wanted to switch the tab:

[Klumbumbus]

(BTW, this setting needs a JOSM restart even if JOSM doesn't ask for it.)