Modify

Opened 6 years ago

Closed 6 years ago

#18149 closed defect (duplicate)

Opening hours validator crashes and asks for a pull request at https://github.com/ypid/opening_hours.js

Reported by: mkoniecz Owned by: team
Priority: trivial Milestone:
Component: Core validator Version:
Keywords: template_report opening_hours Cc:

Description (last modified by mkoniecz)

What steps will reproduce the problem?

  1. Opening hours validator crashes

What is the expected result?

No toast messages asking for pull requests, especially on apparently closed repo.

Note that https://github.com/ypid/opening_hours.js has "Main repo → https://github.com/opening-hours/opening_hours.js" so I am a bit confused.

What happens instead?

- E: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition

resulting in flashing warning.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-09-12 23:23:47 +0200 (Thu, 12 Sep 2019)
Build-Date:2019-09-12 21:28:35
Revision:15348
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15348 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 303 MB / 869 MB (121 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
libcommons-logging-java: libcommons-logging-java:all-1.2-1+build1
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ PicLayer (35104)
+ buildings_tools (34982)
+ continuosDownload (82)
+ ejml (35049)
+ geotools (34908)
+ imagery_offset_db (34908)
+ jts (35064)
+ log4j (34908)
+ measurement (35051)
+ reverter (35084)
+ todo (30306)

Validator rules:
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: Failed to add ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss to tag checker
- W: java.nio.file.NoSuchFileException: ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
- W: Failed to add ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss to tag checker
- W: java.nio.file.NoSuchFileException: ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
- W: Failed to add ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss to tag checker
- W: java.nio.file.NoSuchFileException: ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss
- W: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- E: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- W: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- E: javax.script.ScriptException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause: jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "Mo-Fr 11:00-16:00;Sa-Su 11:30-14:30;SH off". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition

Attachments (0)

Change History (3)

comment:1 by mkoniecz, 6 years ago

Description: modified (diff)

comment:2 by Don-vip, 6 years ago

Keywords: opening_hours added

comment:3 by Don-vip, 6 years ago

Resolution: duplicate
Status: newclosed

Closed as duplicate of #17936.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.