Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#18148 closed defect (fixed)

Duplicate warning for unusual direction

Reported by: naoliv Owned by: team
Priority: normal Milestone: 19.09
Component: Core validator Version:
Keywords: direction Cc: Klumbumbus

Description

Have a node with direction=-100 + highway=speed_camera, validate it and see that we get 2 warnings for the same issue: unusual value of direction

https://i.imgur.com/nXEZJff.png

JOSM:

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-09-17 09:15:17 +0200 (Tue, 17 Sep 2019)
Revision:15354
Build-Date:2019-09-18 01:30:52
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (15354 en) Linux Debian GNU/Linux bullseye/sid
Memory Usage: 520 MB / 6144 MB (212 MB allocated, but free)
Java version: 13+33-Debian-1, Debian, OpenJDK 64-Bit Server VM
Screen: :0.0 1600x900, :0.1 1280x1024
Maximum Screen Size: 1600x1024
Java ATK Wrapper package: libatk-wrapper-java:all-0.36.0-1
libcommons-compress-java: libcommons-compress-java:all-1.18-2
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
liboauth-signpost-java: liboauth-signpost-java:all-1.2.1.2-2
VM arguments: [-Dawt.useSystemAAFontSettings=gasp]
Program arguments: [--language=en]
Dataset consistency test: No problems found

Attachments (0)

Change History (5)

comment:1 by Don-vip, 6 years ago

Cc: Klumbumbus added
Milestone: 19.09

Why do we have two distinct checks in numeric.mapcss since #14989?

*[direction][direction<0],
*[direction][direction>=360] {
  throwWarning: tr("unusual value of {0}", "{0.key}");
  // ...
}
*[direction][direction !~ /^([0-9][0-9]?[0-9]?|north|east|south|west|N|E|S|W|NE|SE|SW|NW|NNE|ENE|ESE|SSE|SSW|WSW|WNW|NNW|forward|backward|both|clockwise|anti-clockwise|anticlockwise|up|down)(-([0-9][0-9]?[0-9]?|N|E|S|W|NE|SE|SW|NW|NNE|ENE|ESE|SSE|SSW|WSW|WNW|NNW))?(;([0-9][0-9]?[0-9]?|N|E|S|W|NE|SE|SW|NW|NNE|ENE|ESE|SSE|SSW|WSW|WNW|NNW)-([0-9][0-9]?[0-9]?|N|E|S|W|NE|SE|SW|NW|NNE|ENE|ESE|SSE|SSW|WSW|WNW|NNW))*$/] {
  throwWarning: tr("unusual value of {0}", "{0.key}");
  // ...
}
Last edited 6 years ago by Don-vip (previous) (diff)

comment:2 by Don-vip, 6 years ago

Keywords: direction added

comment:3 by Klumbumbus, 6 years ago

I was on vacation. I will cath up with JOSM trac in the next days :)

comment:4 by Klumbumbus, 6 years ago

Resolution: fixed
Status: newclosed

In 15383/josm:

fix #18148 - remove duplicate warning for unusual direction

in reply to:  1 comment:5 by Klumbumbus, 6 years ago

Replying to Don-vip:

Why do we have two distinct checks in numeric.mapcss since #14989?

I don't remember. I merged the rules.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.