Integration with OSM wiki data items

[Don-vip]

We could use ​osmwiki:Data_items in several ways:

• validator:
  • automatic rules for wrong geometries (​osmwiki:Property:P33, ​osmwiki:Property:P34, ​osmwiki:Property:P35, ​osmwiki:Property:P36)
  • automatic rules for too small/too big buildings (#17846)
  • detect obsolete, deprecated, discardable values based on their status (​osmwiki:Property:P6)
  • validate values on their regex (​osmwiki:Property:P13)
  • detect missing tags (​osmwiki:Property:P22)
  • detect incompatible tags (​osmwiki:Property:P44)
• presets:
  • fetch and display image+caption in presets dialogs (​osmwiki:Property:P28, ​osmwiki:Property:47)
  • translations of preset name, caption, values?
• UI:
  • go to data item page when right clicking a tag (properties dialog, relation editor, changeset dialog, history dialog...)
  • fetch tag description and display it in a tooltip (#18541)
• plugins
  • tag2link:
    • ​osmwiki:Property:P8 could replace the internal config files
• more?

We could also document some JOSM features on the OSM wiki data items:

• define a "JOSM image" on the same model than "OSM Carto image" (​osmwiki:Property:P39)

Related: #6450 for Taginfo integration

[nyurik]

Thanks @Don-vip for a thorough ticket description :)

I think we might need to create multiple sub-tickets for this. The best first step would be to do the same as iD editor -- use data items to get the multilingual tag documentation (text and an image). Once this is done, we could discuss how we could integrate other features as well.

See related code at ​https://github.com/openstreetmap/iD/blob/fceb1a86f78deaa0853d454a5fe27d08e9f54da0/modules/services/osm_wikibase.js#L122

More specifically, use the API call to wiki to get the relevant data. Note that in the future, the exact same code will be needed to get other information about the data item. ​https://github.com/openstreetmap/iD/blob/fceb1a86f78deaa0853d454a5fe27d08e9f54da0/modules/services/osm_wikibase.js#L183

[frodrigo]

automatic rules for wrong geometries

We already tried this in Osmose-QA back in 2012, based on wikiinfo box. But it was a fail. We removed the control. It raises too many false positives. The wiki shows ideal case, not what is on the ground or acceptable way of mapping anyway.
​https://github.com/osm-fr/osmose-backend/blob/master/plugins/disabled/Wiki.py

[frodrigo]

Some part may be done outside of JOSM, by generating code for tools already existing like JOSM and Osmose-QA.
I am think to generate mapcss and tag2link config, as Osmose-QA also use both.

[Don-vip]

Replying to frodrigo:

automatic rules for wrong geometries

We already tried this in Osmose-QA back in 2012, based on wikiinfo box. But it was a fail. We removed the control. It raises too many false positives. The wiki shows ideal case, not what is on the ground or acceptable way of mapping anyway.

Maybe we can reconsider the issue if everyone (josm, id, vespucci, osmose...) contributes to fixing the false positives on the wiki? We could start by enabling this test in "info" mode to evaluate the number of false positives.