Modify

Opened 4 weeks ago

Closed 4 weeks ago

#17828 closed enhancement (fixed)

New link to ref:ruian:building

Reported by: pschonmann Owned by: Klumbumbus
Priority: normal Milestone:
Component: Plugin tag2link Version: tested
Keywords: RUIAN Czech Cc:

Description (last modified by Don-vip)

Hi, please add new rule to show Czech RUIAN
For Example https://vdp.cuzk.cz/vdp/ruian/stavebniobjekty/43235921

<src name="Czech RUIAN">
        <rule>
                <condition k="ref:ruian:building" v="[0-9]+" />
                <link name="Veřejný dálkový přístup - Detail objektu" href="https://vdp.cuzk.cz/vdp/ruian/stavebniobjekty/%v%" />
        </rule>
</src>

Attachments (0)

Change History (16)

comment:1 Changed 4 weeks ago by Klumbumbus

@Don-vip: I was trying to compile the plugin but failed. My josm core svn is in C:\Users\stefa\Documents\OSM\josm and I created a folder for the plugins at the same level: C:\Users\stefa\Documents\OSM\josm_plugins\tag2link. That seems not to work. Where do I need to check out the plugins related to my josm core svn? Or what else could I have done wrong?

C:\Users\stefa\Documents\OSM\josm_plugins\tag2link>ant clean dist
Buildfile: C:\Users\stefa\Documents\OSM\josm_plugins\tag2link\build.xml

clean:
   [delete] Deleting directory C:\Users\stefa\Documents\OSM\josm_plugins\tag2link\build

init:
    [mkdir] Created dir: C:\Users\stefa\Documents\OSM\josm_plugins\tag2link\build

pre-compile:

compile:
     [echo] compiling sources for C:\Users\stefa\Documents\OSM\dist\tag2link.jar ...
    [javac] Compiling 18 source files to C:\Users\stefa\Documents\OSM\josm_plugins\tag2link\build

BUILD FAILED
C:\Users\stefa\Documents\OSM\josm_plugins\build-common.xml:129: C:\Users\stefa\Documents\OSM\dist does not exist.

Total time: 0 seconds

C:\Users\stefa\Documents\OSM\josm_plugins\tag2link>

comment:2 Changed 4 weeks ago by Don-vip

The recommended way is to checkout the whole thing, see https://josm.openstreetmap.de/wiki/Source%20code#Getthesource:

svn co https://svn.openstreetmap.org/applications/editors/josm

This way, in the "josm" folder you will have the following tree:

  • core: your current "josm" folder
  • dist: the plugin jar files, you need this folder to build a plugin, that's why you have a failure
  • i18n: only needed for i18n updates
  • oldplugins: just an archive of the plugins I have recently removed
  • plugins: the folder of all active plugins + some tools to build them

You can build all plugins by running ant dist in plugins directory, or build them individually by running the same command in the plugin directory (for example tag2link).

You can also run ant install to install the plugin in your JOSM directory.

comment:3 Changed 4 weeks ago by Don-vip

Description: modified (diff)
Keywords: Czech added

comment:4 Changed 4 weeks ago by pschonmann

@Klumbumbus why youre comment offtopic ? This is other issue. I have no probelm with build. Add new issue please. Thanks

comment:5 in reply to:  2 Changed 4 weeks ago by Klumbumbus

Replying to Don-vip:

...

Thanks. I was trying to check out only the plugins I need, because some years ago I already checked out all plugins and I remember that was lots of data and I'm a bit limited on my SSD. What is the total amout size (GB) of data with a full check out?

Last edited 4 weeks ago by Klumbumbus (previous) (diff)

comment:6 in reply to:  4 Changed 4 weeks ago by Klumbumbus

Replying to pschonmann:

@Klumbumbus why youre comment offtopic ?

Because I want to resolve your ticket, so it is technically not offtopic.

comment:7 Changed 4 weeks ago by Don-vip

@pschonmann: even if it was off-topic, core developers would be allowed to do it either way :) Don't worry, your ticket will be fixed.
@Klumbumbus: for a full checkout, consider 5 Gb. For a partial checkout, you will probably need to:

  • rename your josm folder to core
  • checkout the dist folder
  • rename your josm_plugins folder to plugins
  • in the plugins directory:
    • checkout these svn:externals:
      https://josm.openstreetmap.de/svn/trunk/tools 00_core_tools
      https://josm.openstreetmap.de/svn/trunk/test/lib 00_core_test_lib
      https://josm.openstreetmap.de/svn/trunk/test/config 00_core_test_config
      
Last edited 4 weeks ago by Don-vip (previous) (diff)

comment:8 Changed 4 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

comment:9 Changed 4 weeks ago by Klumbumbus

@Don-vip:

  • could you please check if I did all right?
  • the country-code in tag2link_sources.xml doesn't do anything, does it?

@pschonmann: I added it with english text. The translations are done via https://translations.launchpad.net/josm/trunk/+pots/josm

comment:10 Changed 4 weeks ago by Klumbumbus

Not sure if that was me, but the icon which you can see at the screenshot in #13369 is gone.

comment:11 in reply to:  10 ; Changed 4 weeks ago by Klumbumbus

Replying to Klumbumbus:

Not sure if that was me, but the icon which you can see at the screenshot in #13369 is gone.

Ah, after a josm restart the icon appears, so the plugin is not 100% Install without Restart

comment:12 in reply to:  9 Changed 4 weeks ago by Don-vip

Replying to Klumbumbus:

  • could you please check if I did all right?

It seems there's a problem. The plugin info at plugin says:

tag2link.jar;https://svn.openstreetmap.org/applications/editors/josm/dist/tag2link.jar

Ant-Version: Apache Ant 1.10.5
Created-By: 1.8.0_202-b08 (Oracle Corporation)
Plugin-Mainversion: 12847
Plugin-Version: 35025 << this should be 35036

Either you didn't commit the right jar file, or you didn't run svn up after your first commit but before you build the jar file (typical error as it's a little bit tricky). The classic workflow is:

  • code your modifications, build, install and test your plugin locally
  • commit your changes: svn ci -m "fix #josmxxxx - commit message"
  • update your svn repo: svn up
  • build the plugin with updated svn info: ant clean dist
  • commit the jar file: cd ../dist && svn ci -m "dist"
  • the country-code in tag2link_sources.xml doesn't do anything, does it?

Seems not. I don't even remember what I had in mind when I wrote this. Probably the possibility to filter countries in preferences.

Last edited 4 weeks ago by Don-vip (previous) (diff)

comment:13 in reply to:  11 Changed 4 weeks ago by Don-vip

Replying to Klumbumbus:

Not sure if that was me, but the icon which you can see at the screenshot in #13369 is gone.

Ah, after a josm restart the icon appears, so the plugin is not 100% Install without Restart

Can you please create a new defect ticket? I guess it needs some Java programming :)

comment:14 Changed 4 weeks ago by Klumbumbus

Resolution: fixed
Status: closedreopened

Ok I'll try again tomorrow.

comment:15 Changed 4 weeks ago by Klumbumbus

Owner: changed from Don-vip to Klumbumbus
Status: reopenednew

comment:16 Changed 4 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

OK, fixed now in [o35038].
I did build after commiting the changes but probaly did not update svn in between. I guess that was the mistake. Thanks for the help.

Also this time the icon was displayed without restart, so there is probably no bug.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.