[PATCH] incompletely downloaded turn restrictions sometimes break when splitting the from way

[njtbusfan]

It's best to give an example.
ctrl-shift O to download way 696971687 (including referrers). Split it in the middle and note what happens to the no_left_turn relation. In former JOSM versions, it would correctly keep the way next to the via node, but now it doesn't always do it properly.

[Klumbumbus]

This even happens when the turn restriction is downloaded completely. It happens when the western part of way 696971687 is chosen to keep the object id.

[Don-vip]

@Gerd, did you change the split code recently? I don't remember touching this code for years.

[Klumbumbus]

regression is somewhere here: https://josm.openstreetmap.de/log/josm/?action=stop_on_copy&mode=stop_on_copy&rev=15080&stop_rev=15076&limit=900&verbose=on&sfp_email=&sfph_mail=

[Klumbumbus]

Replying to Don-vip:

I don't remember touching this code for years.

I guess you have a bad memory then :P r15078

[Don-vip]

I don't remember patches quite well :) Taylor, can you please take a look?

[njtbusfan]

There's also a problem with no_u_turn relations. Try splitting way 697039202.

[taylor.smock]

I'll double check the code.

All I did was move the restriction handling code to its own function, and added checks for different types of relations that should be treated like a relation. It shouldn't have broken anything, but apparently it did.

It may take me a few days to get around to looking at it due to other constraints.

[Klumbumbus]

Maybe r15076 could be the reason too?

[taylor.smock]

Fix the issue (create private class for return values from specific relation functions) and initial work on a test.

[taylor.smock]

It turns out that I misunderstood the "pointers" in Java and assumed that an variable set to null passed to a function would retain the value assigned to it in the function. This was something that I had been worried about, but in my testing it wasn't actually triggering (probably due to not testing a short section).

Actual steps to reproduce:
1) Split way nearer the "via" node/way

I've added a test to ensure that it doesn't get broken again and fixed the problem by creating a private class with the data that needs to be returned. This does change the function definition, unfortunately.

[Don-vip]

In 15186/josm:

fix #17810 - incompletely downloaded turn restrictions sometimes break when splitting the from way (patch by taylor.smock, modified)

[Don-vip]

Thanks!

[Klumbumbus]

Ticket #17872 has been marked as a duplicate of this ticket.