Modify ↓

Opened 5 years ago

Closed 4 years ago

#17748 closed enhancement (fixed)

Enhancement PicLayer Plugin

Reported by: rebsc Owned by: rebsc
Priority: normal Milestone:
Component: Plugin piclayer Version:
Keywords: Cc:

Description

Hi there,

with ​[o35005] I've committed some new functionality for the ​PicLayer plugin. It helps you to speed up the calibration of an image (preferably floorplans) into world coordinates.
To use this functionality you'll need the image to calibrate, some building dimensions and a file (.osm or .gpx) which stores the final coordinates to know where to locate the image on world map.
The auto-calibration uses already implemented modes of ​PicLayer plugin to calibrate.

Whats different to the manual use?

  • it's faster
  • higher accuracy
  • the insered distances helps you to not deform the image because the image is often more accurate than the given outline (this is why the calibration result often does not fit exactly into the given world coordinates).

There is already a very short description of how to use the auto-calibration in help browser: PicLayer help.
A documentation on ​PicLayer will follow soon.

I would like to hear some feedback!

Rebecca

Attachments (0)

Change History (14)

comment:1 by Don-vip, 5 years ago

There are several things that must be reverted:

  • the unwanted changes of Eclipse .project file
  • the plugin.main.version that goes backward? That's impossible
  • the lang files which are updated, unless you really updated the translations from launchpad? (I don't think so)

comment:2 by Don-vip, 5 years ago

Also, the source code doesn't compile and broke our Jenkins build:

compile:
     [echo] compiling sources for /var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/dist/PicLayer.jar ...
    [javac] Compiling 39 source files to /var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/piclayer/build
    [javac] /var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/piclayer/src/org/openstreetmap/josm/plugins/piclayer/actions/transform/autocalibrate/helper/ObservableArrayList.java:8: error: package javafx.beans.property does not exist
    [javac] import javafx.beans.property.SimpleIntegerProperty;
    [javac]                             ^
    [javac] /var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/piclayer/src/org/openstreetmap/josm/plugins/piclayer/actions/transform/autocalibrate/helper/ObservableArrayList.java:17: error: cannot find symbol
    [javac]     private SimpleIntegerProperty sizeProperty;
    [javac]             ^
    [javac]   symbol:   class SimpleIntegerProperty
    [javac]   location: class ObservableArrayList<E>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in class ObservableArrayList
    [javac] /var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/piclayer/src/org/openstreetmap/josm/plugins/piclayer/actions/transform/autocalibrate/helper/ObservableArrayList.java:23: error: cannot find symbol
    [javac] 	    sizeProperty = new SimpleIntegerProperty(0);
    [javac] 	                       ^
    [javac]   symbol:   class SimpleIntegerProperty
    [javac]   location: class ObservableArrayList<E>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in class ObservableArrayList
    [javac] /var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/piclayer/src/org/openstreetmap/josm/plugins/piclayer/actions/transform/autocalibrate/helper/ObservableArrayList.java:29: error: cannot find symbol
    [javac] 	    sizeProperty = new SimpleIntegerProperty(0);
    [javac] 	                       ^
    [javac]   symbol:   class SimpleIntegerProperty
    [javac]   location: class ObservableArrayList<E>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in class ObservableArrayList
    [javac] /var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/piclayer/src/org/openstreetmap/josm/plugins/piclayer/actions/transform/autocalibrate/helper/ObservableArrayList.java:35: error: cannot find symbol
    [javac] 	    sizeProperty = new SimpleIntegerProperty(0);
    [javac] 	                       ^
    [javac]   symbol:   class SimpleIntegerProperty
    [javac]   location: class ObservableArrayList<E>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in class ObservableArrayList
    [javac] 5 errors

BUILD FAILED
/var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/build.xml:47: The following error occurred while executing this line:
/var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/build.xml:24: The following error occurred while executing this line:
/var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/build-common.xml:125: Compile failed; see the compiler error output for details.

in reply to:  2 comment:3 by rebsc, 5 years ago

Replying to Don-vip:

Also, the source code doesn't compile and broke our Jenkins build:

compile:
     [echo] compiling sources for /var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/dist/PicLayer.jar ...
    [javac] Compiling 39 source files to /var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/piclayer/build
    [javac] /var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/piclayer/src/org/openstreetmap/josm/plugins/piclayer/actions/transform/autocalibrate/helper/ObservableArrayList.java:8: error: package javafx.beans.property does not exist
    [javac] import javafx.beans.property.SimpleIntegerProperty;
    [javac]                             ^
    [javac] /var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/piclayer/src/org/openstreetmap/josm/plugins/piclayer/actions/transform/autocalibrate/helper/ObservableArrayList.java:17: error: cannot find symbol
    [javac]     private SimpleIntegerProperty sizeProperty;
    [javac]             ^
    [javac]   symbol:   class SimpleIntegerProperty
    [javac]   location: class ObservableArrayList<E>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in class ObservableArrayList
    [javac] /var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/piclayer/src/org/openstreetmap/josm/plugins/piclayer/actions/transform/autocalibrate/helper/ObservableArrayList.java:23: error: cannot find symbol
    [javac] 	    sizeProperty = new SimpleIntegerProperty(0);
    [javac] 	                       ^
    [javac]   symbol:   class SimpleIntegerProperty
    [javac]   location: class ObservableArrayList<E>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in class ObservableArrayList
    [javac] /var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/piclayer/src/org/openstreetmap/josm/plugins/piclayer/actions/transform/autocalibrate/helper/ObservableArrayList.java:29: error: cannot find symbol
    [javac] 	    sizeProperty = new SimpleIntegerProperty(0);
    [javac] 	                       ^
    [javac]   symbol:   class SimpleIntegerProperty
    [javac]   location: class ObservableArrayList<E>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in class ObservableArrayList
    [javac] /var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/piclayer/src/org/openstreetmap/josm/plugins/piclayer/actions/transform/autocalibrate/helper/ObservableArrayList.java:35: error: cannot find symbol
    [javac] 	    sizeProperty = new SimpleIntegerProperty(0);
    [javac] 	                       ^
    [javac]   symbol:   class SimpleIntegerProperty
    [javac]   location: class ObservableArrayList<E>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in class ObservableArrayList
    [javac] 5 errors

BUILD FAILED
/var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/build.xml:47: The following error occurred while executing this line:
/var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/build.xml:24: The following error occurred while executing this line:
/var/lib/jenkins/jobs/JOSM-Plugins/workspace/jdk/JDK8/build-common.xml:125: Compile failed; see the compiler error output for details.

Okay, now I see the problem with javafx.
There is some javafx plugin developed by you, is it possible to use it as a dependency to make it work? And if it's possible, should I add -osx, -unixoid and -windows version to the build.xml?
Thanks for the help!

comment:4 by Don-vip, 5 years ago

I don't see why you would need JavaFX just to handle properties. Please use the JOSM property system.

comment:5 by Don-vip, 5 years ago

Can you please fix the build soon? Our Jenkins job for plugins is failing since these modifications.

in reply to:  4 comment:6 by rebsc, 5 years ago

Replying to Don-vip:

I don't see why you would need JavaFX just to handle properties. Please use the JOSM property system.

Alright,
I will revert the .project and the lang files to the version on ​ 35003.
I've updated to the current plugin main version and handled properties without JavaFX what should fix the JavaFX problem.
What's about the .classpath and .settings files, do they need to reverted as well?
Thanks for the help!


comment:7 by Don-vip, 5 years ago

.classpath must be reverted but we can keep the .settings modifications.

in reply to:  7 comment:8 by rebsc, 5 years ago

Replying to Don-vip:

.classpath must be reverted but we can keep the .settings modifications.

I've reverted the .project and .classpath and updated the build and source. You've made some changes on the lang files with the last commit so I left it how it is for now.

comment:9 by Don-vip, 5 years ago

Thanks! Changes for reference: [o35026:35028].
This time the plugin looks correctly built:

PicLayer.jar;https://svn.openstreetmap.org/applications/editors/josm/dist/PicLayer.jar
	Manifest-Version: 1.0
	Ant-Version: Apache Ant 1.10.5
	Created-By: 1.8.0_191-b12 (Oracle Corporation)
	Plugin-Mainversion: 14153
	Plugin-Version: 35027
	Plugin-Class: org.openstreetmap.josm.plugins.piclayer.PicLayerPlugin
	Plugin-Description: This plugin allows to display any picture as a background in the editor and align it with the map.
	Plugin-Date: 2019-06-03T12:35:47.538882Z

comment:10 by Don-vip, 5 years ago

Owner: changed from Larry0ua to rebsc
Priority: trivial → normal

comment:11 by Don-vip, 5 years ago

@rebsc:

  1. can you please check if #17788 is caused by your changes?
  2. are you interested to become the new maintainer of the plugin?

in reply to:  11 ; comment:12 by rebsc, 5 years ago

Replying to Don-vip:

@rebsc:

  1. can you please check if #17788 is caused by your changes?

    Looks like it, I'll fix it soon.

  2. are you interested to become the new maintainer of the plugin?

    If it helps I can keep an eye on it, at least for the next year.

in reply to:  12 comment:13 by Don-vip, 5 years ago

Replying to rebsc:

If it helps I can keep an eye on it, at least for the next year.

It will help a lot, thank you!

comment:14 by rebsc, 4 years ago

Resolution: → fixed
Status: new → closed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain rebsc.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.