Modify

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#17719 closed enhancement (fixed)

Pipeline valve preset extension

Reported by: francois.lacombe Owned by: Don-vip
Priority: normal Milestone: 19.05
Component: Internal preset Version:
Keywords: pipeline, valve Cc:

Description

Hi all,

Following #17694 and https://wiki.openstreetmap.org/wiki/Proposed_features/Pipeline_valves_proposal adoption, I propose to improve Pipeline valve preset as such:

  • add valve={butterfly,globe,ball,plug,gate,needle,spool}
  • add actuator={manual,electric_motor,pneumatic_cylinder,hydraulic_cylinder,thermostatic,solenoid}
  • add handle={lever,wheel,cross,button}
  • add turn_to_close={clockwise,anti_clockwise}
  • add sensor:position={optical,mechanical,inductive,yes}
  • remove substance

Current tagging : https://wiki.openstreetmap.org/wiki/Tag:pipeline%3Dvalve

It is seen here that handle isn't restricted to valves, doors can use it also
https://wiki.openstreetmap.org/wiki/Tag%3Ahandle%3Dwheel

A warning should be raised with such combinations :

  • pipeline valve + actuator=manual with missing handle=* or handle=no

All the best

François

Attachments (3)

josm_vanne_actuator.svg (3.2 KB) - added by francois.lacombe 5 months ago.
Actuator valve only proposal
josm_vanne_handle.svg (6.3 KB) - added by francois.lacombe 5 months ago.
Handle valve only proposal
josm_vanne_handle_actuator.svg (6.3 KB) - added by francois.lacombe 5 months ago.
Handle+actuator valve proposal

Download all attachments as: .zip

Change History (7)

Changed 5 months ago by francois.lacombe

Attachment: josm_vanne_actuator.svg added

Actuator valve only proposal

Changed 5 months ago by francois.lacombe

Attachment: josm_vanne_handle.svg added

Handle valve only proposal

Changed 5 months ago by francois.lacombe

Handle+actuator valve proposal

comment:1 Changed 5 months ago by francois.lacombe

I've added 3 new icon for pipeline=valve

  • Handle only => no actuator OR actuator=manual
  • Actuator only => no handle OR handle=no
  • Actuator + handle => actuator!=manual AND handle!=no

Use them according to needs.

comment:2 Changed 5 months ago by Don-vip

Milestone: 19.05
Owner: changed from team to Don-vip
Status: newassigned

comment:3 Changed 5 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 15139/josm:

fix #17719 - Pipeline valve preset extension

comment:4 Changed 5 months ago by Don-vip

In 15148/josm:

see #17719 - add missing text

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.