Modify

Opened 6 years ago

Closed 6 years ago

#17718 closed enhancement (fixed)

[PATCH] Make it easier to add specially treated relations to SplitWayCommand

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 19.05
Component: Core Version:
Keywords: split way command Cc:

Description

This patch should make it easier to add specially treated relations for splitting to its special case.

This was partially influenced by https://wiki.openstreetmap.org/wiki/Proposed_features/Connectivity -- it is probably a bad idea to break those relations, if they exist.

The current patch is mostly a refactor. It does not add the Connectivity relation type as a special case.

It adds a new static variable with currently existing special cases.
The static variable is a Map<String, String>, with the key being a restriction type and with the value being the specific case (currently, it should only be "restriction"). I've also moved the restriction specific code to its own method, to increase readability if another special case is found/created.

Attachments (1)

17718.patch (7.1 KB ) - added by taylor.smock 6 years ago.
Partial refactor of SplitWayCommand to allow for easier adding of specially treated relations

Download all attachments as: .zip

Change History (3)

by taylor.smock, 6 years ago

Attachment: 17718.patch added

Partial refactor of SplitWayCommand to allow for easier adding of specially treated relations

comment:1 by Don-vip, 6 years ago

Keywords: split way command added
Milestone: 19.05

comment:2 by Don-vip, 6 years ago

Resolution: fixed
Status: newclosed

In 15078/josm:

fix #17718 - Make it easier to add specially treated relations to SplitWayCommand (patch by taylor.smock)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.