Modify

Opened 7 weeks ago

Closed 6 weeks ago

Last modified 6 weeks ago

#17707 closed enhancement (fixed)

Drop branch, voltage and frequency from power plant preset

Reported by: francois.lacombe Owned by: team
Priority: normal Milestone: 19.05
Component: Internal preset Version:
Keywords: infrastructure, power, plant, generator, voltage, frequency Cc:

Description

Dear maintainers,

Power plant preset currently expose fields for voltage and frequency. This could be dropped
Wiki doesn't recommend this while voltage and frequency are generator devices properties (power plant is the enclosing site).
https://wiki.openstreetmap.org/wiki/Tag:power%3Dplant
https://wiki.openstreetmap.org/wiki/Item:Q5792

It's better to have it on power=generator preset (it's currently ok) instead.

Is it possible to add a validation rule that warns when voltage and frequency are used in association with power=plant please?

Finally, branch=* field could be dropped on both power=plant and power=generator as well.

Thanks in advance to take care of this

François

Attachments (0)

Change History (9)

comment:1 Changed 7 weeks ago by Don-vip

Milestone: 19.05

comment:2 Changed 7 weeks ago by Klumbumbus

I don't find any explaination of the key branch in the wiki in the power context. What does key="branch" text="Branch operator" mean? The operator of the electricity grid?

comment:3 Changed 7 weeks ago by Klumbumbus

I was confused about branch already 5 years ago. ticket:10698#comment:4

comment:4 Changed 6 weeks ago by Geozeisig

Can you add plant:source to this preset? It should have values like wind, solar, biomass, hydro, coal gas, nuclear, waste (see Key:plant:source]. It is recommended on the wiki page.

comment:5 Changed 6 weeks ago by francois.lacombe

@Klumbumbus
Indeed, branch=* has a low meaning in power context and that's why I recommand to drop it.
operator=* actually stands for the operator of the power plant (which may differ from the operator of the power grid, for instance in France).
Operator of the power grid doesn't have to be linked on the power plant feature.

Ok with @Geozeisig to add plant:source

comment:6 Changed 6 weeks ago by Klumbumbus

I'm in favor of completely remove the key branch from all our internal power related preset as this is not at all documented in the wiki and the meaning is unclear.

comment:7 Changed 6 weeks ago by francois.lacombe

It's ok for me too
There is no usecase for branch=* in power domain imho.

It's related to some commercial activities
https://wiki.openstreetmap.org/wiki/Key:branch

comment:8 Changed 6 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 15075/josm:

fix #17707

  • remove branch=* from all power related presets
  • remove voltage=* and frequency=* from power=plant presets
  • add a warning about voltage=* and frequency=* on power=plant
  • add plant:source to power=plant presets

comment:9 Changed 6 weeks ago by francois.lacombe

Thank you Klumbumbus

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.