complain about multipolygon with inne member that is not different to mp

[GerdP]

What steps will reproduce the problem?

1. Load attached sample and run validator

What is the expected result?

A warning that the inner on the left has the same area style as the multipolygon.

What happens instead?

no warning

Please provide any additional information below. Attach a screenshot if possible.

We have such a warning for the outer way, but not for the inner. Why not? I assmue it happens rarely in real data.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-04-28 04:36:41 +0200 (Sun, 28 Apr 2019)
Build-Date:2019-04-28 02:37:58
Revision:15031
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15031 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 655 MB / 1820 MB (238 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-XX:StartFlightRecording=name=MyRecording2,settings=d:\dbg\gerd.jfc, -XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true,dumponexitpath=e:\ld\perf_20190511_073341.jfr]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ apache-commons (34908)
+ buildings_tools (34982)
+ continuosDownload (82)
+ ejml (34908)
+ geotools (34908)
+ jaxb (34908)
+ jts (34908)
+ o5m (34908)
+ opendata (34997)
+ pbf (34908)
+ poly (34991)
+ reverter (34977)
+ undelete (34977)
+ utilsplugin2 (34977)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

[GerdP]

My sample produces the message "With the currently used mappaint style the style for inner way equals the multipolygon style (1)" but with severity Other.
I think that is good enough.

[Klumbumbus]

Replying to GerdP:

I assmue it happens rarely in real data.

Valid cases are areas with the same "main tag" but different "sub tags", e.g. a section of broadleaved forest within a needleleaved forest. Therefore it is severity other to avoid too much false positives.

[GerdP]

Yes, I agree. I thought about adding a warning when the inner has exactly the same tags as the relation (except for the type=multipolygon tag). No idea if this happens often in real world data.