Opened 10 years ago
Closed 10 years ago
#10698 closed enhancement (fixed)
[PATCH] Additions to presets for crossing, post_office, bank
Reported by: | Kilkenni | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 14.11 |
Component: | Internal preset | Version: | |
Keywords: | preset, bank, post_office, crossing, chimney | Cc: |
Description (last modified by )
Suggested additions to the existing default presets. I'm a newbie, so feel free to poke at possible problems.
List of changes:
- highway=crossing: button_operated=yes/no, traffic_signals:sound=yes/no
- post_office: ref tag
- bank: ref, branch tags
- man_made=chimney: acceptable object "type=node,closedway" instead of only "node"
All the tags are in the wiki. chimney in current build mismatches the wiki (it's quite logical to map huge industrial chimneys as polygons).
Attachments (1)
Change History (7)
by , 10 years ago
Attachment: | presets-crossing_n_others.patch added |
---|
comment:1 by , 10 years ago
Description: | modified (diff) |
---|
comment:2 by , 10 years ago
follow-up: 4 comment:3 by , 10 years ago
Perhaps. However I feel the urge to include it as I periodically need to add this tag manually for banks. Unfortunately some users currently add info fit for "branch" into "operator" tag as it is encountered more often. That makes searching in OSM more difficult and disrupts data consistency.
The tag is already in default presets for power=* objects, by the way.
Thanks for your feedback :)
comment:4 by , 10 years ago
Replying to Kilkenni:
The tag is already in default presets for power=* objects, by the way.
Which is also dubious. branch
is not documented on any power page in the wiki.
As far as I understand branch
is not clearly defined and documented in the wiki.
comment:5 by , 10 years ago
True enough. I've never used it in power=* myself. But then again, I don't map power objects in detail on the regular basis, so I don't feel it appropriate to talk about whether it should be in power=* or not.
Actually it's not the critical part of the patch (I'm currently using the tag on banks anyway). I've posted the links to the ticket, hopefully we'll see more opinions on the subject soon.
I would omit
branch
. This seems controversial, see Talk:Key:branch and is used "geographical limited" taginfo