Modify

Opened 5 years ago

Closed 5 years ago

#10698 closed enhancement (fixed)

[PATCH] Additions to presets for crossing, post_office, bank

Reported by: Kilkenni Owned by: team
Priority: normal Milestone: 14.11
Component: Internal preset Version:
Keywords: preset, bank, post_office, crossing, chimney Cc:

Description (last modified by Kilkenni)

Suggested additions to the existing default presets. I'm a newbie, so feel free to poke at possible problems.
List of changes:

  • highway=crossing: button_operated=yes/no, traffic_signals:sound=yes/no
  • post_office: ref tag
  • bank: ref, branch tags
  • man_made=chimney: acceptable object "type=node,closedway" instead of only "node"

All the tags are in the wiki. chimney in current build mismatches the wiki (it's quite logical to map huge industrial chimneys as polygons).

Attachments (1)

presets-crossing_n_others.patch (2.3 KB) - added by Kilkenni 5 years ago.

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by Kilkenni

comment:1 Changed 5 years ago by Kilkenni

Description: modified (diff)

comment:2 Changed 5 years ago by Klumbumbus

I would omit branch. This seems controversial, see Talk:Key:branch and is used "geographical limited" taginfo

comment:3 Changed 5 years ago by Kilkenni

Perhaps. However I feel the urge to include it as I periodically need to add this tag manually for banks. Unfortunately some users currently add info fit for "branch" into "operator" tag as it is encountered more often. That makes searching in OSM more difficult and disrupts data consistency.
The tag is already in default presets for power=* objects, by the way.

Thanks for your feedback :)

comment:4 in reply to:  3 Changed 5 years ago by Klumbumbus

Replying to Kilkenni:

The tag is already in default presets for power=* objects, by the way.

Which is also dubious. branch is not documented on any power page in the wiki.

As far as I understand branch is not clearly defined and documented in the wiki.

comment:5 Changed 5 years ago by Kilkenni

True enough. I've never used it in power=* myself. But then again, I don't map power objects in detail on the regular basis, so I don't feel it appropriate to talk about whether it should be in power=* or not.
Actually it's not the critical part of the patch (I'm currently using the tag on banks anyway). I've posted the links to the ticket, hopefully we'll see more opinions on the subject soon.

comment:6 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 7745/josm:

fix #10698 - Additions to presets for crossing, post_office, bank (modified patch by Kilkenni)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.