#10697 closed enhancement (fixed)
[PATCH] fleshing out memorial preset
Reported by: | Kilkenni | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 14.11 |
Component: | Internal preset | Version: | |
Keywords: | preset, memorial | Cc: |
Description
Suggested additions to the "memorial" item in the default presets. I'm a newbie, so feel free to poke at possible problems.
List of changes:
- memorial=* tag for the common memorial types mentioned on the wiki
- inscription tag
- artist_name tag
- start_date tag
- wikipedia tag
- openplaques:id tag
All the tags are in the wiki. openplaques:id seems to be the only one controversial here.
Attachments (1)
Change History (9)
by , 10 years ago
Attachment: | presets-memorial.patch added |
---|
comment:1 by , 10 years ago
comment:3 by , 10 years ago
Replying to Klumbumbus:
any opinions about
openplaques:id
?
There have been quite some discussions about tagging some project's id on tagging@ and the common sense so far is/was that OSM is not the place for these id tags but to use overpass-api.
comment:4 by , 10 years ago
+1. Also it's almost not used, this tag does not deserve to reach default JOSM presets.
comment:5 by , 10 years ago
It can be safely omitted then. I don't see it as crucial, more like a casual timesaver.
Btw, Don-vip, thanks for the notes.
comment:7 by , 10 years ago
I omitted openplaques:id
, replaced tabs by spaces and added spaces before />
.
Replying to Kilkenni:
Thanks for providing a patch! Some remarks: