Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10697 closed enhancement (fixed)

[PATCH] fleshing out memorial preset

Reported by: Kilkenni Owned by: team
Priority: normal Milestone: 14.11
Component: Internal preset Version:
Keywords: preset, memorial Cc:

Description

Suggested additions to the "memorial" item in the default presets. I'm a newbie, so feel free to poke at possible problems.
List of changes:

  • memorial=* tag for the common memorial types mentioned on the wiki
  • inscription tag
  • artist_name tag
  • start_date tag
  • wikipedia tag
  • openplaques:id tag

All the tags are in the wiki. openplaques:id seems to be the only one controversial here.

Attachments (1)

presets-memorial.patch (941 bytes) - added by Kilkenni 5 years ago.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by Kilkenni

Attachment: presets-memorial.patch added

comment:1 in reply to:  description Changed 5 years ago by Don-vip

Replying to Kilkenni:

I'm a newbie, so feel free to poke at possible problems.

Thanks for providing a patch! Some remarks:

  • Setting milestone is usually core developer's privilege :) But as you provides patches for non-controversial items, it's ok. Just let us decide for the next ones :)
  • Be careful with tabs. If you look at your patch through Trac you will see it contains tabs instead of spaces, thus the indentation is wrong

comment:2 Changed 5 years ago by Klumbumbus

any opinions about openplaques:id?

wiki

taginfo

comment:3 in reply to:  2 Changed 5 years ago by skyper

Replying to Klumbumbus:

any opinions about openplaques:id?

wiki

taginfo

There have been quite some discussions about tagging some project's id on tagging@ and the common sense so far is/was that OSM is not the place for these id tags but to use overpass-api.

comment:4 Changed 5 years ago by Don-vip

+1. Also it's almost not used, this tag does not deserve to reach default JOSM presets.

comment:5 Changed 5 years ago by Kilkenni

It can be safely omitted then. I don't see it as crucial, more like a casual timesaver.
Btw, Don-vip, thanks for the notes.

comment:6 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 7701/josm:

fix #10697 - enhance memorial preset (patch by Kilkenni)

comment:7 Changed 5 years ago by Klumbumbus

I omitted openplaques:id, replaced tabs by spaces and added spaces before />.

comment:8 Changed 5 years ago by Klumbumbus

In 7703/josm:

fix #10711 - clean up width in default preset; see #10697 add values_context for memorial

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.