Suspicious code in Geometry.addIntersections()

[GerdP]

The javadoc says

    /**
     * Will find all intersection and add nodes there for list of given ways.
     * Handles self-intersections too.
     * And makes commands to add the intersection points to ways.
     *
     * Prerequisite: no two nodes have the same coordinates.
     *
     * @param ways  a list of ways to test
     * @param test  if false, do not build list of Commands, just return nodes
     * @param cmds  list of commands, typically empty when handed to this method.
     *              Will be filled with commands that add intersection nodes to
     *              the ways.
     * @return list of new nodes
     */

I tried to use this method with a list of multipolygon ways like this
Set<Node> selfIntersections = Geometry.addIntersections(ways, false, null);

I got a NPE because in line 218 there is no check if test is set or not:

if (intNode == newNode) {
    cmds.add(new AddCommand(dataset, intNode));
}

I wonder if JoinAreasAction needs this or if it sometimes fails because of this. It uses the method like this:

    Set<Node> nodes = Geometry.addIntersections(allStartingWays, false, cmds);

[GerdP]

Seems that only the javadoc is wrong. The attached patch fixes this.

If I hear no complains I'll commit this tomorrow.

[Don-vip]

Yep, the javadoc looks wrong, you're right.

[GerdP]

In 15055/josm:

fix #17680: correct misleading javadoc