Modify

Opened 4 months ago

Closed 8 weeks ago

#17681 closed enhancement (fixed)

Add to presets amenity=money_transfer

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 19.06
Component: Internal preset Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. try tagging amenity=money_transfer and shop=money_transfer on nodes
  2. run validator

What is the expected result?

At least one of them is in presets or validator complains.

What happens instead?

No support in rendering or display.

Presets do not contain property value (2)

Please provide any additional information below. Attach a screenshot if possible.

Note that https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dmoney_transfer is documented and currently in iD presets while shop=money transfer has slightly higher use.

See also https://github.com/openstreetmap/iD/issues/6318

Found thanks to https://github.com/osmlab/name-suggestion-index/issues/2598

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-05-03 23:47:54 +0200 (Fri, 03 May 2019)
Build-Date:2019-05-04 01:30:51
Revision:15043
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15043 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 401 MB / 869 MB (137 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ PicLayer (34908)
+ buildings_tools (34982)
+ continuosDownload (82)
+ ejml (34908)
+ geotools (34908)
+ imagery_offset_db (34908)
+ jts (34908)
+ log4j (34908)
+ measurement (34977)
+ reverter (34977)
+ todo (30306)

Validator rules:
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

Attachments (0)

Change History (2)

comment:1 Changed 8 weeks ago by Klumbumbus

Milestone: 19.06

comment:2 Changed 8 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 15199/josm:

fix #17681 - add amenity=money_transfer (icon derived from our atm icon, CC0 and PD licensed), deprecate shop=money_transfer

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.