Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#17629 closed enhancement (fixed)

complain about more descriptive names and propose to delete them [PATCH] — at Version 12

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 19.04
Component: Core validator Version:
Keywords: template_report Cc: stoecker

Description (last modified by mkoniecz)

@Don-vip Are you sure about Rathaus? In Poland removal of name=Ratusz (translates to the same) would be incorrect in many cases, it is often actually a name, even on building=townhall.

Change History (12)

comment:1 by mkoniecz, 7 years ago

Summary: complain about more descriptive names → complain about more descriptive names and propose to delete them

comment:2 by mkoniecz, 7 years ago

Description: modified (diff)

comment:3 by mkoniecz, 7 years ago

BTW, I see also amenity=place_of_worship name=Church, Cami that seems to mean "mosque" in Turkish and used 1500+ in Turkey as a descriptive name - see ​http://overpass-turbo.eu/s/I7u

1500 Biserica meaning "church" in Romanian used for amenity=place_of_worship

3000+ amenity=pharmacy name=Аптека

comment:4 by Don-vip, 7 years ago

List of suspicious names used more than 2000 times to check:

comment:5 by mkoniecz, 7 years ago

​Cmentarz parafialny: 2479 "Parish cemeteries" in Polish?

This is a borderline thing. In some places this is a valid name (in places where there are multiple cemeteries), is some places it is on border of description and actual name, in some places it is a descriptive name.

Kwiatowa, Spacerowa, Zielona, Sportowa, Wiejska, Sosnowa, Wiejska, Łąkowa, Parkowa, Kolejowa, Ogrodowa, Kościelna are all popular street names in Poland. These names are not going to be used as decriptive names due to a grammar form. I am pretty sure that after excluding highway=* usage will drop to nearly 0.

Rynek is for market square, and many of them have it now as the official street name.

name=building is already caught on building=* - see https://josm.openstreetmap.de/browser/josm/trunk/data/validator/unnecessary.mapcss#L97
The same with house, rumah, jalan

Updated lists:

List of suspicious names used more than 2000 times to check:

ones not listed in the list above:

  • amenity=place_of_worship name=Church
  • Cami that seems to mean "mosque" in Turkish and used 1500+ in Turkey as a descriptive name - see ​​http://overpass-turbo.eu/s/I7u
  • 1500 Biserica meaning "church" in Romanian used for amenity=place_of_worship
  • amenity=restaurant name=Restaurant
  • amenity=place_of_worship religion=muslim name=Mosque
  • amenity=toilets name=Toilet
Last edited 7 years ago by mkoniecz (previous) (diff)

comment:6 by mkoniecz, 7 years ago

List of suspicious names used more than 2000 times to check:

And thank you very much for preparing this list!

comment:7 by mkoniecz, 7 years ago

​https://github.com/matkoniecz/josm/tree/descriptive has patch, currently at ​https://github.com/matkoniecz/josm/commit/48bf590c25a0e146921fd4306e4a4b9bfb8e13ce.patch

It removes entries that I initially reported and Pond, all only from objects where this name is both descriptive and provides no additional info.

Equivalent in iD - ​https://github.com/openstreetmap/iD/issues/6055#issuecomment-485131822

Last edited 7 years ago by mkoniecz (previous) (diff)

comment:8 by mkoniecz, 7 years ago

Description: modified (diff)
Summary: complain about more descriptive names and propose to delete them → complain about more descriptive names and propose to delete them [PATCH]

comment:9 by mkoniecz, 7 years ago

After this patch is processed I plan to look again at remaining entries, consult with local communities in cases that are not obvious and make the next patch.

comment:10 by Don-vip, 7 years ago

Milestone: → 19.04

comment:11 by Don-vip, 7 years ago

Resolution: → fixed
Status: new → closed

In 15005/josm:

fix #17629 - complain about more descriptive names and propose to delete them

comment:12 by mkoniecz, 7 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.